Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: Source/bindings/v8/ExceptionState.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased onto df9a982fbe97 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/ExceptionState.h ('k') | Source/bindings/v8/ExceptionStatePlaceholder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 void ExceptionState::throwDOMException(const ExceptionCode& ec, const String& me ssage) 45 void ExceptionState::throwDOMException(const ExceptionCode& ec, const String& me ssage)
46 { 46 {
47 ASSERT(ec); 47 ASSERT(ec);
48 ASSERT(m_isolate); 48 ASSERT(m_isolate);
49 49
50 // SecurityError is thrown via ::throwSecurityError, and _careful_ considera tion must be given to the data exposed to JavaScript via the 'sanitizedMessage'. 50 // SecurityError is thrown via ::throwSecurityError, and _careful_ considera tion must be given to the data exposed to JavaScript via the 'sanitizedMessage'.
51 ASSERT(ec != SecurityError); 51 ASSERT(ec != SecurityError);
52 52
53 m_code = ec; 53 m_code = ec;
54 setException(V8ThrowException::createDOMException(ec, message, m_isolate)); 54 setException(V8ThrowException::createDOMException(ec, message, m_creationCon text, m_isolate));
55 } 55 }
56 56
57 void ExceptionState::throwSecurityError(const String& sanitizedMessage, const St ring& unsanitizedMessage) 57 void ExceptionState::throwSecurityError(const String& sanitizedMessage, const St ring& unsanitizedMessage)
58 { 58 {
59 ASSERT(m_isolate); 59 ASSERT(m_isolate);
60 m_code = SecurityError; 60 m_code = SecurityError;
61 setException(V8ThrowException::createDOMException(SecurityError, sanitizedMe ssage, unsanitizedMessage, m_isolate)); 61 setException(V8ThrowException::createDOMException(SecurityError, sanitizedMe ssage, unsanitizedMessage, m_creationContext, m_isolate));
62 } 62 }
63 63
64 void ExceptionState::setException(v8::Handle<v8::Value> exception) 64 void ExceptionState::setException(v8::Handle<v8::Value> exception)
65 { 65 {
66 // FIXME: Assert that exception is not empty? 66 // FIXME: Assert that exception is not empty?
67 if (exception.IsEmpty()) { 67 if (exception.IsEmpty()) {
68 clearException(); 68 clearException();
69 return; 69 return;
70 } 70 }
71 71
(...skipping 16 matching lines...) Expand all
88 { 88 {
89 m_code = TypeError; 89 m_code = TypeError;
90 } 90 }
91 91
92 void TrackExceptionState::throwSecurityError(const String&, const String&) 92 void TrackExceptionState::throwSecurityError(const String&, const String&)
93 { 93 {
94 m_code = SecurityError; 94 m_code = SecurityError;
95 } 95 }
96 96
97 } // namespace WebCore 97 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/ExceptionState.h ('k') | Source/bindings/v8/ExceptionStatePlaceholder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698