Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: Source/core/rendering/RenderBlockLineLayout.cpp

Issue 685623005: Add missing reset calls after continue in layoutRunsAndFloatsInRange(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Next attempt Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/html/layout-runs-and-floats-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBlockLineLayout.cpp
diff --git a/Source/core/rendering/RenderBlockLineLayout.cpp b/Source/core/rendering/RenderBlockLineLayout.cpp
index c772e506dd661b0a37c2addde17a6415a3110c2e..ae7980eab1ca8b3822327a4bb89e5cdb736820d3 100644
--- a/Source/core/rendering/RenderBlockLineLayout.cpp
+++ b/Source/core/rendering/RenderBlockLineLayout.cpp
@@ -881,6 +881,8 @@ void RenderBlockFlow::layoutRunsAndFloatsInRange(LineLayoutState& layoutState,
// We have to delete this line, remove all floats that got added, and let line layout re-run.
lineBox->deleteLine();
endOfLine = restartLayoutRunsAndFloatsInRange(oldLogicalHeight, oldLogicalHeight + adjustment, lastFloatFromPreviousLine, resolver, previousEndofLine);
+ lineMidpointState.reset();
+ resolver.setPosition(endOfLine, numberOfIsolateAncestors(endOfLine));
dsinclair 2014/11/17 14:12:21 This seems like it could potentially cause issues
continue;
}
« no previous file with comments | « LayoutTests/fast/html/layout-runs-and-floats-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698