Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 685623004: Fix svn commit for deleted files in release scripts. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix svn commit for deleted files in release scripts. BUG=408523 LOG=n TEST=script_test.py TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M tools/push-to-trunk/common_includes.py View 1 chunk +12 lines, -2 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
PTAL. Currently it would ignore deleted files.
6 years, 1 month ago (2014-11-03 12:47:00 UTC) #2
Michael Achenbach
Committed patchset #1 (id:1) manually as 25070 (presubmit successful).
6 years, 1 month ago (2014-11-03 13:17:13 UTC) #3
tandrii(chromium)
6 years, 1 month ago (2014-11-03 14:39:22 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698