Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1955)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 685623002: Move the tests from .html to .sky (Closed)

Created:
6 years, 1 month ago by Hixie
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -11221 lines) Patch
M sky/tests/TestExpectations View 1 chunk +5 lines, -5 lines 0 comments Download
D sky/tests/custom-elements/constructor-calls-created-synchronously.html View 1 chunk +0 lines, -21 lines 0 comments Download
A + sky/tests/custom-elements/constructor-calls-created-synchronously.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/document-register-basic.html View 1 chunk +0 lines, -101 lines 0 comments Download
A + sky/tests/custom-elements/document-register-basic.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/document-register-reentrant-null-constructor.html View 1 chunk +0 lines, -18 lines 0 comments Download
A + sky/tests/custom-elements/document-register-reentrant-null-constructor.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/document-register-reentrant-returning-fake.html View 1 chunk +0 lines, -21 lines 0 comments Download
A + sky/tests/custom-elements/document-register-reentrant-returning-fake.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/document-register-reentrant-throwing-constructor.html View 1 chunk +0 lines, -18 lines 0 comments Download
A + sky/tests/custom-elements/document-register-reentrant-throwing-constructor.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/element-upgrade-no-register-and-leak.html View 1 chunk +0 lines, -13 lines 0 comments Download
A + sky/tests/custom-elements/element-upgrade-no-register-and-leak.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/custom-elements/html-element-type-extension-assert.html View 1 chunk +0 lines, -11 lines 0 comments Download
A + sky/tests/custom-elements/html-element-type-extension-assert.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/custom-elements/lifecycle-created-createElement-recursion.html View 1 chunk +0 lines, -10 lines 0 comments Download
A + sky/tests/custom-elements/lifecycle-created-createElement-recursion.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/custom-elements/lifecycle-created-createElement-reentrancy.html View 1 chunk +0 lines, -29 lines 0 comments Download
A + sky/tests/custom-elements/lifecycle-created-createElement-reentrancy.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/lifecycle-created-parser-script.html View 1 chunk +0 lines, -15 lines 0 comments Download
A + sky/tests/custom-elements/lifecycle-created-parser-script.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/resources/document-register-fuzz.html View 1 chunk +0 lines, -60 lines 0 comments Download
A + sky/tests/custom-elements/resources/document-register-fuzz.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/editing/backspace.html View 1 chunk +0 lines, -20 lines 0 comments Download
A + sky/tests/editing/backspace.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/editing/replace.html View 1 chunk +0 lines, -26 lines 0 comments Download
A + sky/tests/editing/replace.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/editing/selection.html View 1 chunk +0 lines, -26 lines 0 comments Download
A + sky/tests/editing/selection.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/editing/typing.html View 1 chunk +0 lines, -19 lines 0 comments Download
A + sky/tests/editing/typing.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/tests/http/conf/mime.types View 1 chunk +1 line, -0 lines 0 comments Download
D sky/tests/inspector/dom-mutation.html View 1 chunk +0 lines, -37 lines 0 comments Download
A + sky/tests/inspector/dom-mutation.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/inspector/dom-mutation-modify-text-node-and-append.html View 1 chunk +0 lines, -34 lines 0 comments Download
A + sky/tests/inspector/dom-mutation-modify-text-node-and-append.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/lowlevel/abarth.html View 1 chunk +0 lines, -79 lines 0 comments Download
A + sky/tests/lowlevel/abarth.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/lowlevel/attribute-collection.html View 1 chunk +0 lines, -56 lines 0 comments Download
A + sky/tests/lowlevel/attribute-collection.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/lowlevel/camel-case.html View 1 chunk +0 lines, -14 lines 0 comments Download
A + sky/tests/lowlevel/camel-case.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/lowlevel/createElement.html View 1 chunk +0 lines, -112 lines 0 comments Download
A + sky/tests/lowlevel/createElement.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/lowlevel/dom-implementation-create-document.html View 1 chunk +0 lines, -15 lines 0 comments Download
A + sky/tests/lowlevel/dom-implementation-create-document.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/lowlevel/hello-world.html View 1 chunk +0 lines, -4 lines 0 comments Download
A sky/tests/lowlevel/hello-world.sky View 1 chunk +4 lines, -0 lines 0 comments Download
D sky/tests/lowlevel/query-selector.html View 1 chunk +0 lines, -62 lines 0 comments Download
A + sky/tests/lowlevel/query-selector.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/lowlevel/scrollbar.html View 1 chunk +0 lines, -23 lines 0 comments Download
A + sky/tests/lowlevel/scrollbar.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/lowlevel/style-basic.html View 1 chunk +0 lines, -44 lines 0 comments Download
A + sky/tests/lowlevel/style-basic.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/lowlevel/style-specificity.html View 1 chunk +0 lines, -19 lines 0 comments Download
A + sky/tests/lowlevel/style-specificity.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/lowlevel/text.html View 1 chunk +0 lines, -6 lines 0 comments Download
A sky/tests/lowlevel/text.sky View 1 chunk +6 lines, -0 lines 0 comments Download
D sky/tests/mocha/describe-only.html View 1 chunk +0 lines, -20 lines 0 comments Download
A + sky/tests/mocha/describe-only.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mocha/it-only.html View 1 chunk +0 lines, -18 lines 0 comments Download
A + sky/tests/mocha/it-only.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/modules/basic.html View 1 chunk +0 lines, -8 lines 0 comments Download
A sky/tests/modules/basic.sky View 1 chunk +8 lines, -0 lines 0 comments Download
M sky/tests/modules/basic-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/modules/imports-can-import.html View 1 chunk +0 lines, -7 lines 0 comments Download
A + sky/tests/modules/imports-can-import.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/modules/imports-can-import-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/modules/resources/intermediate.html View 1 chunk +0 lines, -7 lines 0 comments Download
A sky/tests/modules/resources/intermediate.sky View 1 chunk +7 lines, -0 lines 0 comments Download
D sky/tests/modules/resources/pass.html View 1 chunk +0 lines, -3 lines 0 comments Download
A sky/tests/modules/resources/pass.sky View 1 chunk +3 lines, -0 lines 0 comments Download
D sky/tests/mutation-observer/callback-arguments.html View 1 chunk +0 lines, -18 lines 0 comments Download
A + sky/tests/mutation-observer/callback-arguments.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/clear-transient-without-delivery.html View 1 chunk +0 lines, -28 lines 0 comments Download
A + sky/tests/mutation-observer/clear-transient-without-delivery.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/create-during-delivery.html View 1 chunk +0 lines, -37 lines 0 comments Download
A + sky/tests/mutation-observer/create-during-delivery.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/cross-document.html View 1 chunk +0 lines, -49 lines 0 comments Download
A + sky/tests/mutation-observer/cross-document.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/delivery-order.html View 1 chunk +0 lines, -40 lines 0 comments Download
A + sky/tests/mutation-observer/delivery-order.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/disconnect-cancel-pending.html View 1 chunk +0 lines, -44 lines 0 comments Download
A + sky/tests/mutation-observer/disconnect-cancel-pending.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/document-fragment-insertion.html View 1 chunk +0 lines, -69 lines 0 comments Download
A + sky/tests/mutation-observer/document-fragment-insertion.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/mutate-during-delivery.html View 1 chunk +0 lines, -34 lines 0 comments Download
A + sky/tests/mutation-observer/mutate-during-delivery.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/mutation-callback-non-element-crash.html View 1 chunk +0 lines, -15 lines 0 comments Download
A + sky/tests/mutation-observer/mutation-callback-non-element-crash.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/mutation-observer/mutation-observer-constructor.html View 1 chunk +0 lines, -28 lines 0 comments Download
A + sky/tests/mutation-observer/mutation-observer-constructor.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/mutation-record-constructor.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + sky/tests/mutation-observer/mutation-record-constructor.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/mutation-record-nullity.html View 1 chunk +0 lines, -42 lines 0 comments Download
A + sky/tests/mutation-observer/mutation-record-nullity.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/observe-attributes.html View 1 chunk +0 lines, -601 lines 0 comments Download
A + sky/tests/mutation-observer/observe-attributes.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/observe-characterdata.html View 1 chunk +0 lines, -229 lines 0 comments Download
A + sky/tests/mutation-observer/observe-characterdata.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/observe-childList.html View 1 chunk +0 lines, -322 lines 0 comments Download
A + sky/tests/mutation-observer/observe-childList.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/observe-exceptions.html View 1 chunk +0 lines, -54 lines 0 comments Download
A + sky/tests/mutation-observer/observe-exceptions.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/observe-options-attributes.html View 1 chunk +0 lines, -34 lines 0 comments Download
A + sky/tests/mutation-observer/observe-options-attributes.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/observe-options-character-data.html View 1 chunk +0 lines, -26 lines 0 comments Download
A + sky/tests/mutation-observer/observe-options-character-data.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/observe-subtree.html View 1 chunk +0 lines, -264 lines 0 comments Download
A + sky/tests/mutation-observer/observe-subtree.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/observer-wrapper-dropoff.html View 1 chunk +0 lines, -28 lines 0 comments Download
A + sky/tests/mutation-observer/observer-wrapper-dropoff.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/mutation-observer/observer-wrapper-dropoff-transient.html View 1 chunk +0 lines, -29 lines 0 comments Download
A + sky/tests/mutation-observer/observer-wrapper-dropoff-transient.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/script-append.html View 1 chunk +0 lines, -27 lines 0 comments Download
A + sky/tests/mutation-observer/script-append.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/shadow-dom.html View 1 chunk +0 lines, -40 lines 0 comments Download
A + sky/tests/mutation-observer/shadow-dom.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/takeRecords.html View 1 chunk +0 lines, -53 lines 0 comments Download
A + sky/tests/mutation-observer/takeRecords.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/mutation-observer/transient-gc-crash.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + sky/tests/mutation-observer/transient-gc-crash.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/mutation-observer/weak-callback-gc-crash.html View 1 chunk +0 lines, -17 lines 0 comments Download
A + sky/tests/mutation-observer/weak-callback-gc-crash.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/parser/comments.html View 1 chunk +0 lines, -15 lines 0 comments Download
A + sky/tests/parser/comments.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/parser/entity.html View 1 chunk +0 lines, -18 lines 0 comments Download
A + sky/tests/parser/entity.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/entity-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/resources/chai.html View 1 chunk +0 lines, -4784 lines 0 comments Download
A + sky/tests/resources/chai.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/resources/dump-as-markup.html View 1 chunk +0 lines, -5 lines 0 comments Download
A + sky/tests/resources/dump-as-markup.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/resources/dump-as-render-tree.html View 1 chunk +0 lines, -5 lines 0 comments Download
A + sky/tests/resources/dump-as-render-tree.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/resources/dump-as-text.html View 1 chunk +0 lines, -5 lines 0 comments Download
A + sky/tests/resources/dump-as-text.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/resources/js-test.html View 1 chunk +0 lines, -590 lines 0 comments Download
A + sky/tests/resources/js-test.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/resources/mocha.html View 1 chunk +0 lines, -2449 lines 0 comments Download
A + sky/tests/resources/mocha.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/services/buffer.html View 1 chunk +0 lines, -9 lines 0 comments Download
A + sky/tests/services/buffer.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/services/codec.html View 1 chunk +0 lines, -9 lines 0 comments Download
A + sky/tests/services/codec.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/services/core.html View 1 chunk +0 lines, -9 lines 0 comments Download
A + sky/tests/services/core.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/services/network.html View 1 chunk +0 lines, -49 lines 0 comments Download
A + sky/tests/services/network.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/styles/border-parsing.html View 1 chunk +0 lines, -14 lines 0 comments Download
A + sky/tests/styles/border-parsing.sky View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tests/styles/inline-style.html View 1 chunk +0 lines, -20 lines 0 comments Download
A + sky/tests/styles/inline-style.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tools/skydb View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/base.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-28 00:34:19 UTC) #2
Hixie
6 years, 1 month ago (2014-10-28 00:35:19 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
155adb76b05f7e0b8d7b90c96fb5dbde8bacdd22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698