Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 685603005: Allow C++11 Delegated Constructors. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years, 1 month ago
Reviewers:
danakj, jamesr
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow C++11 Delegated Constructors. An as-small-as-possible change has been made to JSONReader to test this feature. R=jamesr@chromium.org Committed: https://crrev.com/127772eed524dac861781b03ff22bc9d9a408257 Cr-Commit-Position: refs/heads/master@{#303245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M base/json/json_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M styleguide/c++/c++11.html View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
andersr
6 years, 1 month ago (2014-11-07 14:51:46 UTC) #1
jamesr
lgtm
6 years, 1 month ago (2014-11-07 16:02:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685603005/1
6 years, 1 month ago (2014-11-07 16:03:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22848)
6 years, 1 month ago (2014-11-07 16:07:24 UTC) #6
jamesr
+danakj for base/
6 years, 1 month ago (2014-11-07 16:10:00 UTC) #8
danakj
LGTM
6 years, 1 month ago (2014-11-07 16:11:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685603005/1
6 years, 1 month ago (2014-11-07 16:46:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 17:03:02 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 17:03:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/127772eed524dac861781b03ff22bc9d9a408257
Cr-Commit-Position: refs/heads/master@{#303245}

Powered by Google App Engine
This is Rietveld 408576698