chrome/browser/safe_browsing/download_feedback_service_unittest.cc - Issue 685553002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_feedback_service_unittest.cc

Issue 685553002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service_unittest.cc ('k') | chrome/browser/safe_browsing/download_feedback_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_feedback_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_feedback_service_unittest.cc b/chrome/browser/safe_browsing/download_feedback_service_unittest.cc

index 450524f3cd08de71872a06e81daa99471f434260..1f04532cce5198ea45201151ea666ae79baaa303 100644

--- a/chrome/browser/safe_browsing/download_feedback_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_feedback_service_unittest.cc

@@ -137,14 +137,12 @@ class DownloadFeedbackServiceTest : public testing::Test {

new net::TestURLRequestContextGetter(io_task_runner_)) {

}

- virtual void SetUp() override {

+ void SetUp() override {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

DownloadFeedback::RegisterFactory(&download_feedback_factory_);

}

- virtual void TearDown() override {

- DownloadFeedback::RegisterFactory(NULL);

- }

+ void TearDown() override { DownloadFeedback::RegisterFactory(NULL); }

base::FilePath CreateTestFile(int n) const {

base::FilePath upload_file_path(