remove the GPU checkbox from the hash / database

remove the GPU checkbox from the hash / database

We decided last week that GPU rendering wouldn't be associated
with the fiddle itself; options in the left bar will be split into
ones that are bound to the fiddle (so appear in the hash and database)
and ones that are run-specific (like the rendering mode).

This will leave us better placed to do things like rendering in multiple
modes at once.


BUG=skia:
R=jcgregorio@google.com

Committed: https://skia.googlesource.com/skia/+/9571567802ab7db17ab6d5d7087981c7600f0dcb

[humper, 2014-10-27 21:14:17]

humper@google.com changed reviewers:
+ jcgregorio@google.com

[humper, 2014-10-27 21:14:23]

ptal

[jcgregorio, 2014-10-28 11:42:35]

Does this mean that if I pass a shortcut around I won't know the options that it
was run with? Can we move 'ganesh' to a query parameter in the URL for a fiddle?

[humper, 2014-10-28 15:09:38]

On 2014/10/28 11:42:35, jcgregorio wrote:
> Does this mean that if I pass a shortcut around I won't know the options that
it
> was run with? Can we move 'ganesh' to a query parameter in the URL for a
fiddle?

Yeah, the idea is that a fiddle will contain only the code and width+height (for
now); options that control the output will not be stored.

Eventually we want to be able to run multiple configurations side-by-side, so it
doesn't make sense to store the run configuration with the fiddle; if you want
to say "hey take a look at this on the GPU", you just send someone the fiddle,
they check the GPU box, and run it.

[humper, 2014-10-28 15:10:17]

On 2014/10/28 15:09:38, humper wrote:
> On 2014/10/28 11:42:35, jcgregorio wrote:
> > Does this mean that if I pass a shortcut around I won't know the options
that
> it
> > was run with? Can we move 'ganesh' to a query parameter in the URL for a
> fiddle?
> 
> Yeah, the idea is that a fiddle will contain only the code and width+height
(for
> now); options that control the output will not be stored.
> 
> Eventually we want to be able to run multiple configurations side-by-side, so
it
> doesn't make sense to store the run configuration with the fiddle; if you want
> to say "hey take a look at this on the GPU", you just send someone the fiddle,
> they check the GPU box, and run it.

And yes, we can add query strings to set the non-stored state; I will make that
a separate task.

[jcgregorio, 2014-10-28 17:29:24]

On 2014/10/28 15:10:17, humper wrote:
> On 2014/10/28 15:09:38, humper wrote:
> > On 2014/10/28 11:42:35, jcgregorio wrote:
> > > Does this mean that if I pass a shortcut around I won't know the options
> that
> > it
> > > was run with? Can we move 'ganesh' to a query parameter in the URL for a
> > fiddle?
> > 
> > Yeah, the idea is that a fiddle will contain only the code and width+height
> (for
> > now); options that control the output will not be stored.
> > 
> > Eventually we want to be able to run multiple configurations side-by-side,
so
> it
> > doesn't make sense to store the run configuration with the fiddle; if you
want
> > to say "hey take a look at this on the GPU", you just send someone the
fiddle,
> > they check the GPU box, and run it.
> 
> And yes, we can add query strings to set the non-stored state; I will make
that
> a separate task.

LGTM

[humper, 2014-10-28 17:34:01]

Committed patchset #1 (id:1) manually as
9571567802ab7db17ab6d5d7087981c7600f0dcb (presubmit successful).