Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 685533002: Remove GYP for mojo/shell and mojo/services (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove GYP for mojo/shell and mojo/services This can be built by GN or from the mojo repo (by GN) R=ben@chromium.org TBR=deleting a dead target, sky@chromium.org for testing/buildbot/chromium_trybot.json change Committed: https://crrev.com/22758b88d12e5b6952dea578f5efa17f4d79f0a1 Cr-Commit-Position: refs/heads/master@{#301561}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix android too #

Patch Set 4 : remove mojo_shell_tests from testing/buildbot/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -799 lines) Patch
M build/all.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/mojo.gyp View 1 5 chunks +0 lines, -369 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 chunks +15 lines, -65 lines 0 comments Download
D mojo/mojo_services.gypi View 1 chunk +0 lines, -359 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jamesr
6 years, 1 month ago (2014-10-27 21:15:05 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 1 month ago (2014-10-27 22:22:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685533002/40001
6 years, 1 month ago (2014-10-27 23:57:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/3770)
6 years, 1 month ago (2014-10-28 00:32:09 UTC) #6
jamesr
+sky for testing/buildbot/chromium_trybot.json change, removing mojo_shell_tests
6 years, 1 month ago (2014-10-28 00:38:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685533002/60001
6 years, 1 month ago (2014-10-28 00:40:54 UTC) #10
jamesr
Committed patchset #4 (id:60001) manually as 22758b88d12e5b6952dea578f5efa17f4d79f0a1 (presubmit successful).
6 years, 1 month ago (2014-10-28 04:37:28 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 04:37:30 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/22758b88d12e5b6952dea578f5efa17f4d79f0a1
Cr-Commit-Position: refs/heads/master@{#301561}

Powered by Google App Engine
This is Rietveld 408576698