Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 685523002: Rebaseline imagemagnifier and dropshadowimagefilter tests. (Closed)

Created:
6 years, 1 month ago by Stephen White
Modified:
6 years, 1 month ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rebaseline imagemagnifier and dropshadowimagefilter tests. BUG=skia: TBR=hcm@google.com NOTRY=true Committed: https://skia.googlesource.com/skia/+/0fc71ea432d3895ede198a24080f877e607cd264

Patch Set 1 #

Patch Set 2 : Update to ToT #

Patch Set 3 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -382 lines) Patch
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Android-Nexus5-Adreno330-Arm7-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Nexus5-Adreno330-Arm7-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Nexus9-TegraK1-Arm64-Debug/expected-results.json View 2 chunks +19 lines, -19 lines 0 comments Download
M expectations/gm/Test-Android-Nexus9-TegraK1-Arm64-Release/expected-results.json View 2 chunks +19 lines, -19 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 3 chunks +8 lines, -6 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 3 chunks +8 lines, -6 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 3 chunks +8 lines, -6 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 3 chunks +8 lines, -6 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 3 chunks +8 lines, -6 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 3 chunks +8 lines, -6 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +14 lines, -11 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 5 chunks +14 lines, -11 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +14 lines, -11 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 5 chunks +14 lines, -11 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +14 lines, -11 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 7 chunks +16 lines, -13 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 8 chunks +18 lines, -22 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 8 chunks +18 lines, -22 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 8 chunks +18 lines, -22 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 8 chunks +18 lines, -22 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 10 chunks +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 10 chunks +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 10 chunks +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 10 chunks +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 2 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685523002/20001
6 years, 1 month ago (2014-10-27 21:11:10 UTC) #2
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running git apply --index -3 -p1; error: patch ...
6 years, 1 month ago (2014-10-27 21:11:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685523002/40001
6 years, 1 month ago (2014-10-27 21:12:01 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 0fc71ea432d3895ede198a24080f877e607cd264
6 years, 1 month ago (2014-10-27 21:13:05 UTC) #6
hcm
6 years, 1 month ago (2014-10-28 03:52:20 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/678043003/ by hcm@google.com.

The reason for reverting is: Getting to revert for failures on image filter
tests in Skia and Blink.

Powered by Google App Engine
This is Rietveld 408576698