Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 685503006: Add accessor for can_wake_from_suspend_ in AlarmTimer (Closed)

Created:
6 years, 1 month ago by Chirantan Ekbote
Modified:
6 years, 1 month ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, Eric Caruso
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add accessor for can_wake_from_suspend_ in AlarmTimer Consumers of this class (powerd) might want to know if it actually can wake the system from suspend so that they can try alternatives if it doesn't have this ability. BUG=chrome-os-partner:31970 TBR=derat Committed: https://crrev.com/00dc0d43eac8002ab5e1bc5fe44ce4119ce4aca4 Cr-Commit-Position: refs/heads/master@{#302158}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move accessor to right after dtor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/timers/alarm_timer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Chirantan Ekbote
I'm setting the commit bit now since this is a pretty simple change. Please take ...
6 years, 1 month ago (2014-10-30 00:51:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685503006/1
6 years, 1 month ago (2014-10-30 00:52:56 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-30 00:53:00 UTC) #6
Chirantan Ekbote
Turns out that committer != owner. Please take a look.
6 years, 1 month ago (2014-10-30 01:15:58 UTC) #7
Daniel Erat
lgtm https://codereview.chromium.org/685503006/diff/1/components/timers/alarm_timer.h File components/timers/alarm_timer.h (right): https://codereview.chromium.org/685503006/diff/1/components/timers/alarm_timer.h#newcode75 components/timers/alarm_timer.h:75: bool can_wake_from_suspend() { return can_wake_from_suspend_; } nit: i ...
6 years, 1 month ago (2014-10-30 02:51:21 UTC) #8
Chirantan Ekbote
https://codereview.chromium.org/685503006/diff/1/components/timers/alarm_timer.h File components/timers/alarm_timer.h (right): https://codereview.chromium.org/685503006/diff/1/components/timers/alarm_timer.h#newcode75 components/timers/alarm_timer.h:75: bool can_wake_from_suspend() { return can_wake_from_suspend_; } On 2014/10/30 02:51:21, ...
6 years, 1 month ago (2014-10-30 20:41:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685503006/20001
6 years, 1 month ago (2014-10-30 20:42:13 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 21:24:58 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 21:25:36 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00dc0d43eac8002ab5e1bc5fe44ce4119ce4aca4
Cr-Commit-Position: refs/heads/master@{#302158}

Powered by Google App Engine
This is Rietveld 408576698