extensions/browser/api/cast_channel/cast_socket_unittest.cc - Issue 685503002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_socket_unittest.cc

Issue 685503002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/cast_channel/cast_framer_unittest.cc ('k') | extensions/browser/api/cast_channel/cast_transport_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_socket_unittest.cc

diff --git a/extensions/browser/api/cast_channel/cast_socket_unittest.cc b/extensions/browser/api/cast_channel/cast_socket_unittest.cc

index f31a98a6aecf8d746ac7a6e32e8aa2f5f8b874a5..ba3a7673a1fbd170bd5b428831e8d5489d26b350 100644

--- a/extensions/browser/api/cast_channel/cast_socket_unittest.cc

+++ b/extensions/browser/api/cast_channel/cast_socket_unittest.cc

@@ -349,9 +349,9 @@ class CastSocketTest : public testing::Test {

: logger_(new Logger(

scoped_ptr<base::TickClock>(new base::SimpleTestTickClock),

base::TimeTicks())) {}

- virtual ~CastSocketTest() {}

+ ~CastSocketTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

// Create a few test messages

for (size_t i = 0; i < arraysize(test_messages_); i++) {

CreateStringMessage("urn:cast", "1", "2", kTestData[i],

@@ -363,7 +363,7 @@ class CastSocketTest : public testing::Test {

}

- virtual void TearDown() override {

+ void TearDown() override {

if (socket_.get()) {

EXPECT_CALL(handler_, OnCloseComplete(net::OK));

socket_->Close(base::Bind(&CompleteHandler::OnCloseComplete,