Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 685493002: Autofill - Add Kohls test case (Closed)

Created:
6 years, 1 month ago by Evan Stade
Modified:
6 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Autofill - Add Kohls test case "Address lookup" messes up the address parsing. The card type <select> also fails for some reason. TBR=isherman@chromium.org BUG=427622 Committed: https://crrev.com/ca3a84f73bc29a0e2e28026bba9f7464b68e10b5 Cr-Commit-Position: refs/heads/master@{#301587}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : remove debug line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -0 lines) Patch
M chrome/browser/autofill/form_structure_browsertest.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/input/22_checkout_m_kohls.com.html View 1 chunk +452 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/output/22_checkout_m_kohls.com.out View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Evan Stade
6 years, 1 month ago (2014-10-28 00:32:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685493002/40001
6 years, 1 month ago (2014-10-28 00:36:49 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-28 07:25:55 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 07:26:36 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ca3a84f73bc29a0e2e28026bba9f7464b68e10b5
Cr-Commit-Position: refs/heads/master@{#301587}

Powered by Google App Engine
This is Rietveld 408576698