Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 685463002: Fix typo. (Closed)

Created:
6 years, 1 month ago by Bence
Modified:
6 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix typo. s/canoncial/canonical/ in variable names and comments. No functional change. TBR=brettw BUG= Committed: https://crrev.com/9d5d14145c01519572ff756a580576fddb746b49 Cr-Commit-Position: refs/heads/master@{#301857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M device/bluetooth/bluetooth_device.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_util.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M url/url_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Bence
armansito: PTAL device/bluetooth rch: PTAL net rogerta: PTAL google_apis brettw: PTAL url
6 years, 1 month ago (2014-10-27 16:04:48 UTC) #2
armansito
device/bluetooth: lgtm. Yeah, and LOL
6 years, 1 month ago (2014-10-27 16:35:31 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm google_apis Thanks for doing this cleanup!
6 years, 1 month ago (2014-10-27 16:59:02 UTC) #4
Ryan Hamilton
net/ LGTM Thanks!
6 years, 1 month ago (2014-10-27 17:55:57 UTC) #5
Bence
Since the only change in url/url_util_unittest.cc is in a comment, I'm TBRing brettw.
6 years, 1 month ago (2014-10-29 15:51:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685463002/1
6 years, 1 month ago (2014-10-29 15:52:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 16:37:50 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 16:38:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d5d14145c01519572ff756a580576fddb746b49
Cr-Commit-Position: refs/heads/master@{#301857}

Powered by Google App Engine
This is Rietveld 408576698