Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 685393002: Do not embed array objects in unoptimized code. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Do not embed array objects in unoptimized code. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -83 lines) Patch
M src/ast.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ast-value-factory.h View 3 chunks +27 lines, -32 lines 0 comments Download
M src/ast-value-factory.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M src/messages.js View 1 chunk +17 lines, -0 lines 0 comments Download
M src/parser.cc View 2 chunks +2 lines, -8 lines 0 comments Download
A + test/mjsunit/serialize-embedded-error.js View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 1 month ago (2014-10-30 10:08:38 UTC) #1
Toon Verwaest
lgtm
6 years, 1 month ago (2014-10-30 14:12:12 UTC) #2
Yang
6 years, 1 month ago (2014-10-30 14:21:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25019 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698