Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 685373003: Stop generating ready and error events (Closed)

Created:
6 years, 1 month ago by jrummell
Modified:
6 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Stop generating EME ready and error events Since these events are no longer used by the unprefixed EME code, there is no need to pass them to blink. Full removal will happen when the prefixed EME code is removed. BUG=418260 TEST=existing EME tests pass Committed: https://crrev.com/bd184fd6cf0fe78f64d30ae9f17bf6e45714ec90 Cr-Commit-Position: refs/heads/master@{#302348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -37 lines) Patch
M content/renderer/media/cdm_session_adapter.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M content/renderer/media/webcontentdecryptionmodulesession_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/webcontentdecryptionmodulesession_impl.cc View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jrummell
PTAL.
6 years, 1 month ago (2014-10-30 21:18:12 UTC) #2
ddorwin
Please add EME to the first line of the description. Then LGTM.
6 years, 1 month ago (2014-10-31 21:49:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685373003/1
6 years, 1 month ago (2014-10-31 21:58:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 23:22:34 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 23:23:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd184fd6cf0fe78f64d30ae9f17bf6e45714ec90
Cr-Commit-Position: refs/heads/master@{#302348}

Powered by Google App Engine
This is Rietveld 408576698