Chromium Code Reviews| Index: PRESUBMIT.py |
| diff --git a/PRESUBMIT.py b/PRESUBMIT.py |
| index 2c405655b6c9962dd0c5310942594c013728f168..ee872e269c047ec2b64fafdb93537f3d7bc0149f 100644 |
| --- a/PRESUBMIT.py |
| +++ b/PRESUBMIT.py |
| @@ -1621,17 +1621,21 @@ def GetDefaultTryConfigs(bots=None): |
| 'linux_chromium_gn_dbg': ['compile'], |
| 'linux_chromium_gn_rel': ['defaulttests'], |
| 'linux_chromium_rel': ['defaulttests'], |
| + 'linux_chromium_rel_ng': ['defaulttests'], |
| 'linux_chromium_clang_dbg': ['defaulttests'], |
| 'linux_gpu': ['defaulttests'], |
| 'linux_nacl_sdk_build': ['compile'], |
| 'mac_chromium_compile_dbg': ['defaulttests'], |
| 'mac_chromium_rel': ['defaulttests'], |
|
Sergiy Byelozyorov
2014/10/30 10:16:40
Why keep the old ones?
Paweł Hajdan Jr.
2014/10/30 10:19:10
This helps avoid a possible presubmit crash with a
Sergiy Byelozyorov
2014/10/30 10:39:24
Can you elaborate please? Why would presubmit use
Paweł Hajdan Jr.
2014/10/30 10:48:59
Please see "dereference" on line 1645 and trace ba
Sergiy Byelozyorov
2014/10/30 10:52:57
The downside is keeping dead code. But I see now h
|
| + 'mac_chromium_rel_ng': ['defaulttests'], |
| 'mac_gpu': ['defaulttests'], |
| 'mac_nacl_sdk_build': ['compile'], |
| 'win_chromium_compile_dbg': ['defaulttests'], |
| 'win_chromium_dbg': ['defaulttests'], |
| 'win_chromium_rel': ['defaulttests'], |
| + 'win_chromium_rel_ng': ['defaulttests'], |
| 'win_chromium_x64_rel': ['defaulttests'], |
| + 'win_chromium_x64_rel_ng': ['defaulttests'], |
| 'win_gpu': ['defaulttests'], |
| 'win_nacl_sdk_build': ['compile'], |
| 'win8_chromium_rel': ['defaulttests'], |
| @@ -1681,12 +1685,12 @@ def GetPreferredTryMasters(project, change): |
| if all(re.search(r'\.(m|mm)$|(^|[\\\/_])mac[\\\/_.]', f) for f in files): |
| return GetDefaultTryConfigs([ |
| 'mac_chromium_compile_dbg', |
| - 'mac_chromium_rel', |
| + 'mac_chromium_rel_ng', |
| ]) |
| if all(re.search('(^|[/_])win[/_.]', f) for f in files): |
| return GetDefaultTryConfigs([ |
| 'win_chromium_dbg', |
| - 'win_chromium_rel', |
| + 'win_chromium_rel_ng', |
| 'win8_chromium_rel', |
| ]) |
| if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) for f in files): |
| @@ -1712,14 +1716,14 @@ def GetPreferredTryMasters(project, change): |
| 'linux_chromium_clang_dbg', |
| 'linux_chromium_gn_dbg', |
| 'linux_chromium_gn_rel', |
| - 'linux_chromium_rel', |
| + 'linux_chromium_rel_ng', |
| 'linux_gpu', |
| 'mac_chromium_compile_dbg', |
| - 'mac_chromium_rel', |
| + 'mac_chromium_rel_ng', |
| 'mac_gpu', |
| 'win_chromium_compile_dbg', |
| - 'win_chromium_rel', |
| - 'win_chromium_x64_rel', |
| + 'win_chromium_rel_ng', |
| + 'win_chromium_x64_rel_ng', |
| 'win_gpu', |
| 'win8_chromium_rel', |
| ] |