Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: base/PRESUBMIT.py

Issue 685363002: Update PRESUBMIT files for first round of ng trybots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Chromium presubmit script for src/base. 5 """Chromium presubmit script for src/base.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details on the presubmit API built into gcl. 8 for more details on the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 28 matching lines...) Expand all
39 def CheckChangeOnUpload(input_api, output_api): 39 def CheckChangeOnUpload(input_api, output_api):
40 results = [] 40 results = []
41 results.extend(_CommonChecks(input_api, output_api)) 41 results.extend(_CommonChecks(input_api, output_api))
42 return results 42 return results
43 43
44 44
45 def CheckChangeOnCommit(input_api, output_api): 45 def CheckChangeOnCommit(input_api, output_api):
46 results = [] 46 results = []
47 results.extend(_CommonChecks(input_api, output_api)) 47 results.extend(_CommonChecks(input_api, output_api))
48 return results 48 return results
49
50
51 def GetPreferredTryMasters(project, change):
Sergiy Byelozyorov 2014/10/30 10:16:40 Why is this (and others) being removed? Shouldn't
Paweł Hajdan Jr. 2014/10/30 10:19:10 This is redundant since top-level presubmit file a
Sergiy Byelozyorov 2014/10/30 10:38:24 Is top-level PRESUBMIT executed when there is a mo
Paweł Hajdan Jr. 2014/10/30 10:40:49 All of them get executed, please see http://dev.ch
Sergiy Byelozyorov 2014/10/30 10:52:57 Acknowledged.
52 return {
53 'tryserver.chromium.linux': {
54 'linux_chromium_rel': set(['defaulttests']),
55 },
56 'tryserver.chromium.mac': {
57 'mac_chromium_rel': set(['defaulttests']),
58 },
59 'tryserver.chromium.win': {
60 'win_chromium_rel': set(['defaulttests']),
61 }
62 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698