Remove pre-scaling code from NativeImageSkia.

Remove pre-scaling code from NativeImageSkia.

This is properly handled by Skia.

After this CL, NativeImageSkia is a very thin wrapper around an SkBitmap.

BUG=391051
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184668

[jbroman, 2014-10-30 02:56:54]

jbroman@chromium.org changed reviewers:
+ schenney@chromium.org

[jbroman, 2014-10-30 02:56:55]

I think we can finally remove all this code and let Skia take full control of
this scaling. See Patch Set 1 for what the failures are; these seem fine to
rebaseline.

Look reasonable to you?

[reed1, 2014-10-30 13:08:25]

reed@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[reed1, 2014-10-30 13:08:26]

drive by comment : will be nice when we can replace that entire class with
SkImage.

[jbroman, 2014-10-30 13:15:00]

On 2014/10/30 13:08:26, reed1 wrote:
> drive by comment : will be nice when we can replace that entire class with
> SkImage.

I've been fiddling with a CL that inlines SkBitmap (since after this it's a
"pointer to SkBitmap"), though I'm not sure if it's a good idea or not. I must
admit I'm not terribly familiar with SkImage.

[reed1, 2014-10-30 13:20:16]

On 2014/10/30 13:15:00, jbroman wrote:
> On 2014/10/30 13:08:26, reed1 wrote:
> > drive by comment : will be nice when we can replace that entire class with
> > SkImage.
> 
> I've been fiddling with a CL that inlines SkBitmap (since after this it's a
> "pointer to SkBitmap"), though I'm not sure if it's a good idea or not. I must
> admit I'm not terribly familiar with SkImage.

SkImage is a little nicer / more-modern, in that it is already thread-safe and
refcountable, and can encapsulate direct pixels, lazy pixels, and gpu-backed
pixels.

No rush, I think the current CL is great as is.

[f(malita), 2014-10-30 18:20:40]

lgtm, lvgtm!

[humper, 2014-10-30 18:24:33]

On 2014/10/30 18:20:40, Florin Malita wrote:
> lgtm, lvgtm!

Yes!

[jbroman, 2014-10-30 20:22:49]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2014-10-30 20:23:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/685333003/20001

[commit-bot: I haz the power, 2014-10-30 20:32:35]

Committed patchset #2 (id:20001) as 184668