Chromium Code Reviews

Issue 68533014: Improve Blob constructor error messages. (Closed)

Created:
7 years, 1 month ago by sof
Modified:
7 years, 1 month ago
Reviewers:
haraken, Mike West, jochen (gone - plz use gerrit), Inactive
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, kinuko, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Improve Blob constructor error messages. Follow current practice of supplying the name of the constructor in the error message string, along with normalizing formatting and wording used. Also took the opportunity of simplifying how toV8Sequence() reports a type error: a non-sequence argument is now indicated by returning v8Undefined(). R=ch.dumez@samsung.com BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161849

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+44 lines, -51 lines)
M LayoutTests/fast/files/blob-constructor-expected.txt View 3 chunks +12 lines, -12 lines 0 comments
M LayoutTests/fast/files/script-tests/blob-constructor.js View 3 chunks +12 lines, -12 lines 0 comments
M Source/bindings/v8/V8Binding.h View 7 chunks +10 lines, -17 lines 0 comments
M Source/bindings/v8/V8Utilities.cpp View 1 chunk +3 lines, -3 lines 0 comments
M Source/bindings/v8/custom/V8BlobCustom.cpp View 5 chunks +7 lines, -7 lines 0 comments

Messages

Total messages: 6 (0 generated)
sof
At your leisure, please take a look.
7 years, 1 month ago (2013-11-12 19:49:41 UTC) #1
Inactive
lgtm
7 years, 1 month ago (2013-11-12 20:03:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/68533014/1
7 years, 1 month ago (2013-11-12 20:06:56 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 1 month ago (2013-11-12 21:05:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/68533014/1
7 years, 1 month ago (2013-11-12 21:28:45 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 21:33:05 UTC) #6
Message was sent while issue was closed.
Change committed as 161849

Powered by Google App Engine