Issue 68533011: win: x86 targets XP subsystem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68533011: win: x86 targets XP subsystem (Closed)

Created:
7 years, 1 month ago by scottmg

Modified:
7 years, 1 month ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

win: x86 targets XP subsystem The default in the VS2013 compiler has been switched to Vista+, however the runtime library still supports XP if the PE header is set properly. So, make sure the subsystem is set to 5.01 so that gyp-built binaries can be run on XP. R=thakis@chromium.org BUG=chromium:297971 Committed: https://code.google.com/p/gyp/source/detail?r=1784

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	pylib/gyp/msvs_emulation.py	View		1 chunk	+11 lines, -1 line	0 comments	Download
	M	test/win/gyptest-link-subsystem.py	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

http://build.chromium.org/p/tryserver.nacl/builders/gyp-win64/builds/1403/steps/msvs-2010/logs/stdio looks unhappy.

7 years, 1 month ago (2013-11-12 04:24:53 UTC) #2

scottmg

On 2013/11/12 04:24:53, Nico (ooo until Nov 12) wrote: > http://build.chromium.org/p/tryserver.nacl/builders/gyp-win64/builds/1403/steps/msvs-2010/logs/stdio > looks unhappy. Looks ...

7 years, 1 month ago (2013-11-12 04:26:00 UTC) #3

Nico

7 years, 1 month ago (2013-11-17 05:12:09 UTC) #5

Message was sent while issue was closed.

gyp-win64 has been red since this landed:
http://build.chromium.org/f/client/gyp/

Expand Messages | Collapse Messages