Issue 68533003: pdfviewer: compile pdfviewer in gm, only if the flag is set (currently we compile pdfviewer, even i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68533003: pdfviewer: compile pdfviewer in gm, only if the flag is set (currently we compile pdfviewer, even i… (Closed)

Created:
7 years, 1 month ago by edisonn

Modified:
7 years, 1 month ago

Reviewers:
jvanverth1, scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

pdfviewer: compile pdfviewer in gm, only if the flag is set (currently we compile pdfviewer, even if it is not used) Committed: http://code.google.com/p/skia/source/detail?r=12249

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
M	gyp/gm.gyp	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	gyp/utils.gyp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/utils/SkPDFRasterizer.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/utils/SkPDFRasterizer.cpp	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/edisonn@google.com/68533003/1

7 years, 1 month ago (2013-11-12 15:21:20 UTC) #4

edisonn

updated the cl no to compile pdfviewer at all if it is not needed - ...

7 years, 1 month ago (2013-11-12 15:49:38 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/edisonn@google.com/68533003/130001

7 years, 1 month ago (2013-11-12 17:29:31 UTC) #7

Message was sent while issue was closed.

Change committed as 12249