Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 68523010: Fixes bug where MessagePumpMojo was listening for state on the wrong handle (Closed)

Created:
7 years, 1 month ago by sky
Modified:
7 years, 1 month ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Fixes bug where MessagePumpMojo was listening for state on the wrong handle Test will be forth coming, but wanted to land this now. BUG=none TEST=none R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/common/message_pump_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
7 years, 1 month ago (2013-11-13 22:55:38 UTC) #1
viettrungluu
lgtm
7 years, 1 month ago (2013-11-13 22:58:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/68523010/1
7 years, 1 month ago (2013-11-13 23:14:24 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-14 00:00:19 UTC) #4
sky
7 years, 1 month ago (2013-11-14 00:15:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r234973 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698