Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 685213005: Avoid warning in nanobench related to loop count with nvprmsaa4 (Closed)

Created:
6 years, 1 month ago by Kimmo Kinnunen
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Avoid warning in nanobench related to loop count with nvprmsaa4 The tests path_hairline_{small,big}_AA_conic were calling the test function with NVPR. This caused a warning in nanobench. The here removed hunk comes from commit referring to skia:2042 ("Enable NVPR by default"). This is a workaround for a bug. The bug is fixed by the commit referring to skia:2078 ("Logan bot fails NVPR assertion in bench"). The proper fix is indeed make sure that path renderer chain ends up trying software path renderer, if the path contains conics and is a hairline. The removed hunk refers also to skia:2033 ("Figure out what is happening with conic path segments in NVPR"). The above solution is correct also in case NVPR would support conics, as NVPR would not still support hairlines. BUG=skia:2078 Committed: https://skia.googlesource.com/skia/+/839425177ca20c7e0916716b6a19291980a25e7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M bench/HairlinePathBench.cpp View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kimmo Kinnunen
Robert, was there any particular reason you left the ifdef at its place when you ...
6 years, 1 month ago (2014-11-11 14:28:55 UTC) #2
robertphillips
On 2014/11/11 14:28:55, Kimmo Kinnunen wrote: > Robert, > was there any particular reason you ...
6 years, 1 month ago (2014-11-11 14:46:46 UTC) #3
robertphillips
lgtm
6 years, 1 month ago (2014-11-11 14:47:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685213005/1
6 years, 1 month ago (2014-11-11 14:48:20 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 14:57:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/839425177ca20c7e0916716b6a19291980a25e7a

Powered by Google App Engine
This is Rietveld 408576698