Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 685213004: Refactor: Extract some general code for asymmetric algorithms from RSA files. (Closed)

Created:
6 years, 1 month ago by eroman
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@jwk_refactor
Project:
chromium
Visibility:
Public.

Description

Refactor: Extract some general code for asymmetric algorithms from RSA files. The code for importing/exporting pkcs8/spki is not specific to RSA. Extracting it so it can be shared by the EC implementation. BUG=399094 Committed: https://crrev.com/5be54f7258f8d3967c716bed2f7f87608c3024fd Cr-Commit-Position: refs/heads/master@{#302090}

Patch Set 1 #

Patch Set 2 : moare #

Total comments: 5

Patch Set 3 : tweak a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -162 lines) Patch
M content/child/webcrypto/openssl/rsa_key_openssl.cc View 1 2 17 chunks +47 lines, -162 lines 0 comments Download
M content/child/webcrypto/openssl/util_openssl.h View 2 chunks +35 lines, -0 lines 0 comments Download
M content/child/webcrypto/openssl/util_openssl.cc View 3 chunks +130 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eroman
https://codereview.chromium.org/685213004/diff/20001/content/child/webcrypto/openssl/util_openssl.cc File content/child/webcrypto/openssl/util_openssl.cc (right): https://codereview.chromium.org/685213004/diff/20001/content/child/webcrypto/openssl/util_openssl.cc#newcode24 content/child/webcrypto/openssl/util_openssl.cc:24: Status ExportPKeySpki(EVP_PKEY* key, std::vector<uint8_t>* buffer) { No changes made ...
6 years, 1 month ago (2014-10-29 22:12:10 UTC) #2
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-10-30 02:34:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685213004/40001
6 years, 1 month ago (2014-10-30 15:52:38 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-30 16:40:27 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 16:41:23 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5be54f7258f8d3967c716bed2f7f87608c3024fd
Cr-Commit-Position: refs/heads/master@{#302090}

Powered by Google App Engine
This is Rietveld 408576698