Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: chrome/browser/extensions/extension_updater_unittest.cc

Issue 6852029: [Sync] Move some extension-sync-related logic to ExtensionService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address asargent's comments Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/stl_util-inl.h" 9 #include "base/stl_util-inl.h"
10 #include "base/string_number_conversions.h" 10 #include "base/string_number_conversions.h"
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 virtual void CheckForUpdatesSoon() { 125 virtual void CheckForUpdatesSoon() {
126 FAIL(); 126 FAIL();
127 } 127 }
128 128
129 virtual PendingExtensionManager* pending_extension_manager() { 129 virtual PendingExtensionManager* pending_extension_manager() {
130 ADD_FAILURE() << "Subclass should override this if it will " 130 ADD_FAILURE() << "Subclass should override this if it will "
131 << "be accessed by a test."; 131 << "be accessed by a test.";
132 return &pending_extension_manager_; 132 return &pending_extension_manager_;
133 } 133 }
134 134
135 virtual void ProcessSyncData(
136 const ExtensionSyncData& extension_sync_data,
137 PendingExtensionInfo::ShouldAllowInstallPredicate
138 should_allow_install) {
139 FAIL();
140 }
141
135 Profile* profile() { return &profile_; } 142 Profile* profile() { return &profile_; }
136 143
137 ExtensionPrefs* extension_prefs() { return prefs_.prefs(); } 144 ExtensionPrefs* extension_prefs() { return prefs_.prefs(); }
138 145
139 PrefService* pref_service() { return prefs_.pref_service(); } 146 PrefService* pref_service() { return prefs_.pref_service(); }
140 147
141 // Creates test extensions and inserts them into list. The name and 148 // Creates test extensions and inserts them into list. The name and
142 // version are all based on their index. If |update_url| is non-null, it 149 // version are all based on their index. If |update_url| is non-null, it
143 // will be used as the update_url for each extension. 150 // will be used as the update_url for each extension.
144 // The |id| is used to distinguish extension names and make sure that 151 // The |id| is used to distinguish extension names and make sure that
(...skipping 1065 matching lines...) Expand 10 before | Expand all | Expand 10 after
1210 1217
1211 // TODO(asargent) - (http://crbug.com/12780) add tests for: 1218 // TODO(asargent) - (http://crbug.com/12780) add tests for:
1212 // -prodversionmin (shouldn't update if browser version too old) 1219 // -prodversionmin (shouldn't update if browser version too old)
1213 // -manifests & updates arriving out of order / interleaved 1220 // -manifests & updates arriving out of order / interleaved
1214 // -malformed update url (empty, file://, has query, has a # fragment, etc.) 1221 // -malformed update url (empty, file://, has query, has a # fragment, etc.)
1215 // -An extension gets uninstalled while updates are in progress (so it doesn't 1222 // -An extension gets uninstalled while updates are in progress (so it doesn't
1216 // "come back from the dead") 1223 // "come back from the dead")
1217 // -An extension gets manually updated to v3 while we're downloading v2 (ie 1224 // -An extension gets manually updated to v3 while we're downloading v2 (ie
1218 // you don't get downgraded accidentally) 1225 // you don't get downgraded accidentally)
1219 // -An update manifest mentions multiple updates 1226 // -An update manifest mentions multiple updates
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_sync_data.cc ('k') | chrome/browser/extensions/mock_extension_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698