Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 6852004: Move bvt suite into test harness. (Closed)

Created:
9 years, 9 months ago by sosa
Modified:
9 years, 7 months ago
Reviewers:
dgarrett
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Move bvt suite into test harness. Change-Id: I816fb4825814048aeb911e206067b9e1f6b8cfe4 BUG=chromium-os:12950 TEST=Ran it with buildbot change. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e3bf9c0

Patch Set 1 #

Patch Set 2 : Fix to parallel job #

Total comments: 1

Patch Set 3 : Rebased #

Patch Set 4 : Pass rate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M au_test_harness/au_test.py View 1 2 2 chunks +12 lines, -2 lines 0 comments Download
M au_test_harness/vm_au_worker.py View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
9 years, 9 months ago (2011-04-13 23:38:20 UTC) #1
dgarrett
9 years, 9 months ago (2011-04-14 00:08:17 UTC) #2
LGTM, except that doesn't whoever was explicitly calling "SimpleTest" need to be
updated? Or will it catch both new test because they share the prefix?

http://codereview.chromium.org/6852004/diff/1001/au_test_harness/parallel_tes...
File au_test_harness/parallel_test_job.py (right):

http://codereview.chromium.org/6852004/diff/1001/au_test_harness/parallel_tes...
au_test_harness/parallel_test_job.py:67: return (active_count, active_job)
This looks like a valid, but separate change. Doesn't need another change list,
but I'd put it in the description.

Powered by Google App Engine
This is Rietveld 408576698