Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 685173002: Revert of Use SkTypeface::getBounds() in bounding-box calculations. (Closed)

Created:
6 years, 1 month ago by mtklein
Modified:
6 years, 1 month ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Use SkTypeface::getBounds() in bounding-box calculations. (patchset #3 id:40001 of https://codereview.chromium.org/680363003/) Reason for revert: http://build.chromium.org/p/client.skia/builders/Test-Win7-ShuttleA-HD2000-x86-Debug/builds/97/steps/nanobench/logs/stdio Original issue's description: > Use SkTypeface::getBounds() in bounding-box calculations. > > This should produce tighter conservative bounding boxes for text than the > approximation code it replaces. > > Recording performance is neutral on my desktop. Playback performance > improves by up to 15% on text heavy pages, e.g. > > desk_pokemonwiki.skp_1 3.24ms -> 2.83ms 0.87x > desk_baidu.skp_1 1.91ms -> 1.58ms 0.83x > > Committed: https://skia.googlesource.com/skia/+/bf8dc343df4fbdcb8af546eb68b640e011a33489 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/27f965a577262deb9182c6935f3af05bb52b817c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -29 lines) Patch
M src/core/SkRecordDraw.cpp View 4 chunks +15 lines, -24 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Use SkTypeface::getBounds() in bounding-box calculations.
6 years, 1 month ago (2014-10-29 15:32:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685173002/1
6 years, 1 month ago (2014-10-29 15:33:30 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 15:33:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 27f965a577262deb9182c6935f3af05bb52b817c

Powered by Google App Engine
This is Rietveld 408576698