Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 685153004: scale xmin and xmax for FontMetrics (Closed)

Created:
6 years, 1 month ago by reed2
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

scale xmin and xmax for FontMetrics BUG=skia: Committed: https://skia.googlesource.com/skia/+/79c276e4fd93d9c9fd57a45bc6929c48e4415b2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reed1
6 years, 1 month ago (2014-10-29 20:34:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685153004/1
6 years, 1 month ago (2014-10-29 20:34:36 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-29 20:34:37 UTC) #5
mtklein
lgtm
6 years, 1 month ago (2014-10-29 20:34:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 79c276e4fd93d9c9fd57a45bc6929c48e4415b2f
6 years, 1 month ago (2014-10-29 20:43:54 UTC) #7
robertphillips
6 years, 1 month ago (2014-10-30 16:59:01 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/691033002/ by robertphillips@google.com.

The reason for reverting is: Experimental revert to see if this is blocking the
DEPS roll.

Powered by Google App Engine
This is Rietveld 408576698