Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/sessions/session_service_unittest.cc

Issue 685133004: Handling |SessionCommand|s as scoped_ptr's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/sessions/session_service_commands.h ('K') | « chrome/browser/sessions/session_service_test_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/session_service_unittest.cc
diff --git a/chrome/browser/sessions/session_service_unittest.cc b/chrome/browser/sessions/session_service_unittest.cc
index e77a970164fac0311be2e074b6acc4c94421ea53..84ef15355d2827c627a89e2baf17034f62925732 100644
--- a/chrome/browser/sessions/session_service_unittest.cc
+++ b/chrome/browser/sessions/session_service_unittest.cc
@@ -913,8 +913,8 @@ TEST_F(SessionServiceTest, RestoreActivation1) {
CreateAndWriteSessionWithTwoWindows(
window2_id, tab1_id, tab2_id, &nav1, &nav2);
- service()->ScheduleCommand(CreateSetActiveWindowCommand(window2_id));
- service()->ScheduleCommand(CreateSetActiveWindowCommand(window_id));
+ service()->ScheduleCommand(CreateSetActiveWindowCommand(window2_id).Pass());
+ service()->ScheduleCommand(CreateSetActiveWindowCommand(window_id).Pass());
ScopedVector<SessionWindow> windows;
SessionID::id_type active_window_id = 0;
@@ -934,9 +934,9 @@ TEST_F(SessionServiceTest, RestoreActivation2) {
CreateAndWriteSessionWithTwoWindows(
window2_id, tab1_id, tab2_id, &nav1, &nav2);
- service()->ScheduleCommand(CreateSetActiveWindowCommand(window2_id));
- service()->ScheduleCommand(CreateSetActiveWindowCommand(window_id));
- service()->ScheduleCommand(CreateSetActiveWindowCommand(window2_id));
+ service()->ScheduleCommand(CreateSetActiveWindowCommand(window2_id).Pass());
+ service()->ScheduleCommand(CreateSetActiveWindowCommand(window_id).Pass());
+ service()->ScheduleCommand(CreateSetActiveWindowCommand(window2_id).Pass());
ScopedVector<SessionWindow> windows;
SessionID::id_type active_window_id = 0;
« chrome/browser/sessions/session_service_commands.h ('K') | « chrome/browser/sessions/session_service_test_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698