Handling |SessionCommand|s as scoped_ptr's

chrome/browser/sessions/base_session_service.cc

Index: chrome/browser/sessions/base_session_service.cc
diff --git a/chrome/browser/sessions/base_session_service.cc b/chrome/browser/sessions/base_session_service.cc
index 05d61bf7213b1a55a42df2c457d4335db8df9d81..7af894985cbb7ce4b49116c94cc204111ce35a61 100644
--- a/chrome/browser/sessions/base_session_service.cc
+++ b/chrome/browser/sessions/base_session_service.cc
@@ -67,10 +67,10 @@ void BaseSessionService::DeleteLastSession() {
       base::Bind(&SessionBackend::DeleteLastSession, backend()));
 }
 
-void BaseSessionService::ScheduleCommand(SessionCommand* command) {
+void BaseSessionService::ScheduleCommand(scoped_ptr<SessionCommand> command) {
   DCHECK(command);
   commands_since_reset_++;
-  pending_commands_.push_back(command);
+  pending_commands_.push_back(command.release());
   StartSaveTimer();
 }
 
@@ -91,15 +91,17 @@ void BaseSessionService::Save() {
   if (pending_commands_.empty())
     return;
 
+  // We create a new ScopedVector which will receive all elements from the
+  // current commands. This will also clear the current list.
+  ScopedVector<SessionCommand>* passed = new ScopedVector<SessionCommand>();

[sky, 2014/10/30 22:51:07]

ScopedVector supports move semantics. Can't you supply pending_commands_ to the
constructor and have it effectively inline what you have here? Additionally,
because it supports move semantics there should be no need for a pointer
anymore. ScopedVector should work.

[Mr4D (OOO till 08-26), 2014/10/30 23:31:21]

Aha. ScopedVector.passed() works. Interesting. Done.

For the base::Bind however... I tried various things to use a scoped_ptr and it
did not work. Bind is apparently doing some assigns which would need to use
.Pass which they do not.

+  passed->swap(pending_commands_);
+  DCHECK(pending_commands_.empty());
   RunTaskOnBackendThread(
       FROM_HERE,
       base::Bind(&SessionBackend::AppendCommands, backend(),
-                 new std::vector<SessionCommand*>(pending_commands_),
+                 passed,
                  pending_reset_));
 
-  // Backend took ownership of commands.
-  pending_commands_.clear();
-
   if (pending_reset_) {
     commands_since_reset_ = 0;
     pending_reset_ = false;