Does not override default animation when closing a docked window

Does not override default animation when closing a docked window

BUG=317204
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234697

[varkha, 2013-11-11 15:55:00]

+jamescook, could you please take a look? This now avoids modifying default
animation when a window gets hidden - unless a window is in fact getting
minimized. This affects closing a docked window as well as hiding a docked
window when another window gets fullscreen (including immersive) - now both
those scenarios use default hiding fade out. Thanks!

[pkotwicz, 2013-11-11 18:10:50]

LGTM with nit

https://codereview.chromium.org/68513003/diff/1/ash/wm/dock/docked_window_lay...
File ash/wm/dock/docked_window_layout_manager.cc (right):

https://codereview.chromium.org/68513003/diff/1/ash/wm/dock/docked_window_lay...
ash/wm/dock/docked_window_layout_manager.cc:609: window,
base::TimeDelta::FromMilliseconds(kFadeDurationMs));
You should be explicit about the animation type you want in the |visible| case.
(Things would not work as expected if someone changed the default animation
type)

[James Cook, 2013-11-11 18:28:23]

LGTM with Peter's nit

[varkha, 2013-11-11 20:18:29]

https://codereview.chromium.org/68513003/diff/1/ash/wm/dock/docked_window_lay...
File ash/wm/dock/docked_window_layout_manager.cc (right):

https://codereview.chromium.org/68513003/diff/1/ash/wm/dock/docked_window_lay...
ash/wm/dock/docked_window_layout_manager.cc:609: window,
base::TimeDelta::FromMilliseconds(kFadeDurationMs));
On 2013/11/11 18:10:51, pkotwicz wrote:
> You should be explicit about the animation type you want in the |visible|
case.
> (Things would not work as expected if someone changed the default animation
> type)

Done (I think). This is matching the type set in
GetWindowVisibilityAnimationType().

[commit-bot: I haz the power, 2013-11-11 20:39:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/68513003/100001

[commit-bot: I haz the power, 2013-11-12 23:51:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/68513003/100001

[commit-bot: I haz the power, 2013-11-13 01:29:54]

Change committed as 234697