Issue 685123007: Restore special interceptor stub for keyed loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 685123007: Restore special interceptor stub for keyed loads. (Closed)

Created:
6 years, 1 month ago by mvstanton

Modified:
6 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Restore special interceptor stub for keyed loads. V8 bleeding edge r24042 (https://code.google.com/p/v8/source/detail?r=24042) introduced handlers for interceptors, but this tanked Dromeo dom query. R=verwaest@chromium.org BUG=419220 LOG=N

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -53 lines)			Patch
M	src/builtins.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/builtins.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	src/ic/handler-compiler.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/ic/ic.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/ic/ic.cc	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	src/ic/ic-compiler.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/ic/x64/ic-x64.cc	View	1 chunk	+43 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+0 lines, -31 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

mvstanton

6 years, 1 month ago (2014-10-30 13:01:28 UTC) #1

Hi Toon,
This is a straightforward revert modulo some changes in ic.cc
KeyedLoadIC::Load().

I've just got x64 now, will upload ports.
Thanks,
--Michael

Expand Messages | Collapse Messages