cloud_print/service/win/chrome_launcher.cc - Issue 685103004: Refactor chrome_launcher_support::GetAnyChromePath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/chrome_launcher.cc

Issue 685103004: Refactor chrome_launcher_support::GetAnyChromePath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix app_installer compile. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/service/win/chrome_launcher.cc

diff --git a/cloud_print/service/win/chrome_launcher.cc b/cloud_print/service/win/chrome_launcher.cc

index d63dc8f0b4000b7502d35ea8c99599105e87bf11..2b1ce8007d0121486fa6bec2cdadfac19725fac9 100644

--- a/cloud_print/service/win/chrome_launcher.cc

+++ b/cloud_print/service/win/chrome_launcher.cc

@@ -198,7 +198,8 @@ void ChromeLauncher::Run() {

for (base::TimeDelta time_out = default_time_out;;

time_out = std::min(time_out * 2, max_time_out)) {

- base::FilePath chrome_path = chrome_launcher_support::GetAnyChromePath();

+ base::FilePath chrome_path =

+ chrome_launcher_support::GetAnyChromePath(false /* is_sxs */);

if (!chrome_path.empty()) {

base::CommandLine cmd(chrome_path);

@@ -258,7 +259,8 @@ std::string ChromeLauncher::CreateServiceStateFile(

return std::string();

}

- base::FilePath chrome_path = chrome_launcher_support::GetAnyChromePath();

+ base::FilePath chrome_path =

+ chrome_launcher_support::GetAnyChromePath(false /* is_sxs */);

if (chrome_path.empty()) {

LOG(ERROR) << "Can't find Chrome.";

return std::string();