cloud_print/service/win/service_listener.cc - Issue 685103004: Refactor chrome_launcher_support::GetAnyChromePath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/service_listener.cc

Issue 685103004: Refactor chrome_launcher_support::GetAnyChromePath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/service/win/service_listener.cc

diff --git a/cloud_print/service/win/service_listener.cc b/cloud_print/service/win/service_listener.cc

index 0aaf0f305848d531318f0a293f19b23841129cfc..f80e75982fd66e0c94e42318e7c2b6709d929403 100644

--- a/cloud_print/service/win/service_listener.cc

+++ b/cloud_print/service/win/service_listener.cc

@@ -35,8 +35,9 @@ std::string GetEnvironment(const base::FilePath& user_data_dir) {

printing::XPSModule::Init());

environment.SetString(SetupListener::kUserNameJsonValueName,

GetCurrentUserName());

- environment.SetString(SetupListener::kChromePathJsonValueName,

- chrome_launcher_support::GetAnyChromePath().value());

+ environment.SetString(

+ SetupListener::kChromePathJsonValueName,

+ chrome_launcher_support::GetAnyChromePath(false).value());

grt (UTC plus 2) 2015/01/12 14:02:42 would you mind adding /* is_sxs */ here and in por

Matt Giuca 2015/01/13 08:22:00 Done.

if (base::CreateDirectory(user_data_dir)) {

base::FilePath temp_file;

if (base::CreateTemporaryFileInDir(user_data_dir, &temp_file)) {