Refactor chrome_launcher_support::GetAnyChromePath.

cloud_print/service/win/chrome_launcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cloud_print/service/win/chrome_launcher.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
@@ skipping 180 matching lines @@
   thread_->Join();
   thread_.reset();
 }
 
 void ChromeLauncher::Run() {
   const base::TimeDelta default_time_out = base::TimeDelta::FromSeconds(1);
   const base::TimeDelta max_time_out = base::TimeDelta::FromHours(1);
 
   for (base::TimeDelta time_out = default_time_out;;
        time_out = std::min(time_out * 2, max_time_out)) {
-    base::FilePath chrome_path = chrome_launcher_support::GetAnyChromePath();
+    base::FilePath chrome_path =
+        chrome_launcher_support::GetAnyChromePath(false);

[Matt Giuca, 2014/10/30 02:54:50]

Question for Vitaly: Is there a reason why cloud_print is not getting the SxS
(canary) path for Canary builds? Is it not supported?

Maybe in the future this will make it easier to launch a Canary Chrome.

[grt (UTC plus 2), 2014/10/30 16:44:53]

The canary population is extremely small, and in most cases Canary can't be made
the default browser. I can see adding a fallback here to use canary if regular
Chrome isn't installed, but my gut tells me that non-canary should always be
preferred. The only exception to this would be if there's a very simple way to
determine that canary is actually the user's default browser when both are
installed. Since this is rarely the case, I wouldn't put a lot of effort into
coding it.

[Vitaly Buka (NO REVIEWS), 2014/10/30 16:46:17]

It's OK to try Canary first here and then fallback to regular one.

[Matt Giuca, 2015/01/09 06:17:32]

Echoing my statements in chrome_launcher_support.cc, I don't know why you would
want a canary cloud_print to use regular Chrome and vice versa.

Certainly the non-canary cloud_print should not be using canary Chrome. Why
would a canary cloud_print want to fall back to regular Chrome? (If you have
canary cloud_print, then surely you have canary Chrome installed.)

[grt (UTC plus 2), 2015/01/09 17:45:28]

Is the only path to installing canary cloud print via SxS Chrome? If the two are
intertwined, then yeah, launch canary from canary and regular from regular.

[Matt Giuca, 2015/01/12 06:54:26]

I don't know. Vitaly, can you answer this?

TBH I would prefer to keep the original functionality here (of launching the
regular Chrome only). This CL is a refactor, and should not be changing
functionality (especially since the author is completely unfamiliar with cloud
print). If indeed there is a bug here (canary cloud print only launches stable
Chrome), then that should have its own crbug and CL to fix.

[Vitaly Buka (NO REVIEWS), 2015/01/12 08:24:43]

sgtm.

There is no canary build of cloud print service and currently service always
uses non SxS Chrome. It would be nice to find a way to use SxS to testing or
troubleshooting, but you are right, it's a separate issue.

So lets keep just "false" here then.

On 2015/01/12 06:54:26, Matt Giuca wrote:

[grt (UTC plus 2), 2015/01/12 14:02:41]

SGTM

 
     if (!chrome_path.empty()) {
       CommandLine cmd(chrome_path);
       CopyChromeSwitchesFromCurrentProcess(&cmd);
 
       // Required switches.
       cmd.AppendSwitchASCII(switches::kProcessType, switches::kServiceProcess);
       cmd.AppendSwitchPath(switches::kUserDataDir, user_data_);
       cmd.AppendSwitch(switches::kNoServiceAutorun);
 
@@ skipping 39 matching lines @@
 
 std::string ChromeLauncher::CreateServiceStateFile(
     const std::string& proxy_id,
     const std::vector<std::string>& printers) {
   base::ScopedTempDir temp_user_data;
   if (!temp_user_data.CreateUniqueTempDir()) {
     LOG(ERROR) << "Can't create temp dir.";
     return std::string();
   }
 
-  base::FilePath chrome_path = chrome_launcher_support::GetAnyChromePath();
+  base::FilePath chrome_path = chrome_launcher_support::GetAnyChromePath(false);
   if (chrome_path.empty()) {
     LOG(ERROR) << "Can't find Chrome.";
     return std::string();
   }
 
   base::FilePath printers_file = temp_user_data.path().Append(L"printers.json");
 
   base::ListValue printer_list;
   printer_list.AppendStrings(printers);
   std::string printers_json;
@@ skipping 41 matching lines @@
       LOG(ERROR) << "Chrome launch failed.";
       return std::string();
     }
     if (!json.empty()) {
       // Close chrome because Service State is ready.
       CloseChrome(chrome_handle.Get(), thread_id);
       return json;
     }
   }
 }