Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 6851023: verity: don't call page_address on unmapped highmem pages (Closed)

Created:
9 years, 6 months ago by Mandeep Singh Baines
Modified:
9 years, 5 months ago
Reviewers:
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

verity: don't call page_address on unmapped highmem pages This fixes a bug that is preventing ARM systems from booting with verity. We were calling page_address on what could potentially have been an unmapped highmem page. Fix is to pass the struct page to the crypto code and let crypto handle the kmap/kunmap. BUG=chromium-os:14089, chrome-os-partner:3287 TEST=Ran dm-verity.git unit tests. Ran platform_DMVerityCorruption on H/W. Verified that ARM now boots. kernel-next.git Review URL: http://codereview.chromium.org/6835032 TBRing. Code has already been reviewed and committed to kernel-next.git There are some trivial changes here to the unittest to match the new list of parameters. Change-Id: Id9e025552aee323e95d50aa9798a964510710fdd Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=847ad0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -40 lines) Patch
M dm-bht.h View 1 chunk +1 line, -1 line 0 comments Download
M dm-bht.c View 8 chunks +15 lines, -21 lines 0 comments Download
M dm-bht_unittest.cc View 7 chunks +26 lines, -19 lines 0 comments Download
A include/linux/mm_types.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698