Chromium Code Reviews
Help | Chromium Project | Sign in
(763)

Issue 6851017: Pin down app-editors/vim as the virtual/editor in chromeos ebuild. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by mtennant
Modified:
2 years, 11 months ago
Reviewers:
davidjames, anush
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Pin down app-editors/vim as the virtual/editor in chromeos ebuild.

Some packages, such as sudo, have a dependency on 'virtual/editor'. This can
resolve to different editors depending on what editors are pulled in by other
packages. For example, x86 builds were getting 'nano' and arm builds were
getting 'vim'. To make this more deterministic the chromeos ebuild has been
changed to definitively select vim as the editor of choice.

Note that vim was chosen by the build team lead as the primary editor to be supported on chromeos builds.

BUG=chromium-os:5777
TEST=build_image now includes app-editors/vim, with USE=minimal, for chromeos package

Change-Id: I8fd6dfed632dabad7d8c4f2e0ce8377a046252ae

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=04272b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Lint Patch
M chromeos-base/chromeos/chromeos-0.0.1.ebuild View 1 chunk +7 lines, -0 lines 0 comments ? errors Download
M profiles/targets/chromeos/package.use View 1 chunk +1 line, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
mtennant
For review
3 years ago #1
davidjames
3 years ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6