Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 685053002: Treat regular and always-on hotwording settings as mutually exclusive. (Closed)

Created:
6 years, 1 month ago by Anand Mistry (off Chromium)
Modified:
6 years, 1 month ago
Reviewers:
benwells, Evan Stade
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, rlp+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Treat regular and always-on hotwording settings as mutually exclusive. Only one should be set, so update functions to reflect this. In the rare case both are set, always-on takes precedence. BUG=397019 Committed: https://crrev.com/c82af9411c9c8f0b3d43f709642ac892e1a2c36d Cr-Commit-Position: refs/heads/master@{#302382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/browser/resources/hotword/launcher_manager.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/hotword/page_audio_manager.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/hotword/state_manager.js View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (4 generated)
Anand Mistry (off Chromium)
benwells@chromium.org: Please review changes in start_page_service estade@chromium.org: Please review changes in c/b/r/hotword/*
6 years, 1 month ago (2014-10-29 02:04:34 UTC) #2
benwells
lgtm
6 years, 1 month ago (2014-10-29 06:13:48 UTC) #3
Evan Stade
rslgtm
6 years, 1 month ago (2014-10-29 22:36:44 UTC) #4
Evan Stade
rslgtm
6 years, 1 month ago (2014-10-29 22:36:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685053002/1
6 years, 1 month ago (2014-10-29 23:35:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21109)
6 years, 1 month ago (2014-10-29 23:43:22 UTC) #9
Anand Mistry (off Chromium)
On 2014/10/29 22:36:45, Evan Stade wrote: > rslgtm presubmit doesn't recognise this as an lgtm.
6 years, 1 month ago (2014-10-30 00:12:07 UTC) #10
Matt Giuca
Please edit the title of this CL: s/settigns/settings/
6 years, 1 month ago (2014-10-30 00:12:52 UTC) #11
Anand Mistry (off Chromium)
On 2014/10/30 00:12:52, Matt Giuca wrote: > Please edit the title of this CL: s/settigns/settings/ ...
6 years, 1 month ago (2014-10-30 00:43:02 UTC) #12
Evan Stade
On 2014/10/30 00:43:02, Anand Mistry wrote: > On 2014/10/30 00:12:52, Matt Giuca wrote: > > ...
6 years, 1 month ago (2014-10-31 18:30:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685053002/1
6 years, 1 month ago (2014-11-01 09:10:02 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-01 09:48:32 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 09:49:15 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c82af9411c9c8f0b3d43f709642ac892e1a2c36d
Cr-Commit-Position: refs/heads/master@{#302382}

Powered by Google App Engine
This is Rietveld 408576698