Windows-specific implementation of Networking Private API.

Windows-specific implementation of Networking Private API.

Previously reviewed as https://codereview.chromium.org/27722003, but
moves WiFiService Windows implementation to components/wifi.

Based on infrastructure in https://codereview.chromium.org/54323003/

BUG=267667
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236816

[mef, 2013-11-19 22:25:37]

Hi guys, please take a look.

This is windows-specific implementation of Networking Private API. 

It was previously reviewed as https://codereview.chromium.org/27722003, but per
jam@'s suggestion base infrastructure has been changed to get rid of utility
process (https://codereview.chromium.org/54323003), so I think it is worth
another review.

With removal of chrome/utility/wifi I heeded joi@'s suggestion and moved
WiFiService  implementation to components/wifi. 

I've also changed WiFiService interface to synchronous, posted to worker
threads, and that has simplified the threading and understanding.

Could you please review the following:

joi@ - components/wifi/*
finnur@ - chrome/common/extensions/api/_api_features.json.
jam@ - chrome/*.gyp* and FYI overall.
afontan - FYI components/wifi/* and overall.

thanks,
-m

[Jói, 2013-11-20 11:08:40]

LGTM for //components.

https://codereview.chromium.org/68503019/diff/20001/components/wifi/wifi_serv...
File components/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/68503019/diff/20001/components/wifi/wifi_serv...
components/wifi/wifi_service_win.cc:134: class WiFiServiceImpl : public
WiFiService, base::NonThreadSafe {
A minor nit on naming; it's inconsistent to use WiFiXyz when your filenames use
wifi_xyz. It should either be WiFiXyz and wi_fi_xyz, or it should be WifiXyz and
wifi_xyz.

I don't think this is important enough for you to necessarily change it though.

[Finnur, 2013-11-20 11:13:15]

_api_features.json LGTM

[jam, 2013-11-21 19:38:49]

On 2013/11/19 22:25:37, mef wrote:
> Hi guys, please take a look.
> 
> This is windows-specific implementation of Networking Private API. 
> 
> It was previously reviewed as https://codereview.chromium.org/27722003, but
per
> jam@'s suggestion base infrastructure has been changed to get rid of utility
> process (https://codereview.chromium.org/54323003), so I think it is worth
> another review.
> 
> With removal of chrome/utility/wifi I heeded joi@'s suggestion and moved
> WiFiService  implementation to components/wifi. 
> 
> I've also changed WiFiService interface to synchronous, posted to worker
> threads, and that has simplified the threading and understanding.
> 
> Could you please review the following:
> 
> joi@ - components/wifi/*
> finnur@ - chrome/common/extensions/api/_api_features.json.
> jam@ - chrome/*.gyp* and FYI overall.

there are no gypi files for me to look at? as for overall, I'll defer to the
other reviewers :)

> afontan - FYI components/wifi/* and overall.
> 
> thanks,
> -m

[commit-bot: I haz the power, 2013-11-22 18:23:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mef@chromium.org/68503019/220001

[commit-bot: I haz the power, 2013-11-22 20:25:57]

Change committed as 236816