cc: Alow animations to be aborted from either thread

cc: Alow animations to be aborted from either thread

This makes LayerAnimationController correctly handle animations that are
aborted on the compositor thread. It also adds an AbortAnimations method that
aborts all animations with a particular target property.

These changes are needed for implementing the CSSOM View smooth scroll API,
since we will require the ability to abort scroll animations on the
compositor thread as a result of input events received by the compositor
thread.

BUG=243871
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235557

[ajuma, 2013-11-14 21:56:03]

PTAL.

https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
File cc/animation/layer_animation_controller.h (right):

https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
cc/animation/layer_animation_controller.h:45: Animation::TargetProperty
target_property);
These were marked "virtual for testing", but none of these seem to be overridden
anywhere.

[Ian Vollick, 2013-11-15 01:48:56]

https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
File cc/animation/layer_animation_controller.cc (right):

https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
cc/animation/layer_animation_controller.cc:622: continue;
Won't continuing here prevent us from sending events for the rest of the
animations in the group?

https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
cc/animation/layer_animation_controller.cc:655:
active_animations_[i]->run_state() != Animation::Aborted) {
We could never get here if the run state is aborted, I don't think. You've got
that 'continue' above that would prevent it.

https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
File cc/animation/layer_animation_controller.h (right):

https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
cc/animation/layer_animation_controller.h:45: Animation::TargetProperty
target_property);
On 2013/11/14 21:56:03, ajuma wrote:
> These were marked "virtual for testing", but none of these seem to be
overridden
> anywhere.
Thanks for fixing up the comment/virts.

[ajuma, 2013-11-15 18:07:34]

PTAL.

https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
File cc/animation/layer_animation_controller.cc (right):

https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
cc/animation/layer_animation_controller.cc:622: continue;
On 2013/11/15 01:48:56, Ian Vollick wrote:
> Won't continuing here prevent us from sending events for the rest of the
> animations in the group?

We're iterating over active_animations_ (rather than over group_id), so if there
are other animations in the group we'll get to them in a later iteration of the
loop.

https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
cc/animation/layer_animation_controller.cc:655:
active_animations_[i]->run_state() != Animation::Aborted) {
On 2013/11/15 01:48:56, Ian Vollick wrote:
> We could never get here if the run state is aborted, I don't think. You've got
> that 'continue' above that would prevent it.

Good catch! This was mean to be active_animations_[j], not
active_animations_[i]. I've fixed this and added tests.

[Ian Vollick, 2013-11-15 18:41:10]

On 2013/11/15 18:07:34, ajuma wrote:
> PTAL.
> 
>
https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
> File cc/animation/layer_animation_controller.cc (right):
> 
>
https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
> cc/animation/layer_animation_controller.cc:622: continue;
> On 2013/11/15 01:48:56, Ian Vollick wrote:
> > Won't continuing here prevent us from sending events for the rest of the
> > animations in the group?
> 
> We're iterating over active_animations_ (rather than over group_id), so if
there
> are other animations in the group we'll get to them in a later iteration of
the
> loop.
> 
>
https://codereview.chromium.org/68503014/diff/1/cc/animation/layer_animation_...
> cc/animation/layer_animation_controller.cc:655:
> active_animations_[i]->run_state() != Animation::Aborted) {
> On 2013/11/15 01:48:56, Ian Vollick wrote:
> > We could never get here if the run state is aborted, I don't think. You've
got
> > that 'continue' above that would prevent it.
> 
> Good catch! This was mean to be active_animations_[j], not
> active_animations_[i]. I've fixed this and added tests.

lgtm

[commit-bot: I haz the power, 2013-11-15 18:57:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajuma@chromium.org/68503014/110001

[commit-bot: I haz the power, 2013-11-15 22:10:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajuma@chromium.org/68503014/110001

[commit-bot: I haz the power, 2013-11-16 00:40:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajuma@chromium.org/68503014/110001

[commit-bot: I haz the power, 2013-11-17 21:31:30]

Change committed as 235557