Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: LayoutTests/fast/dom/element-attribute-js-null.html

Issue 68503013: Remove TreatNullAs=NullString for <frame>, <frameset> and <iframe> (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/element-attribute-js-null-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/element-attribute-js-null.html
diff --git a/LayoutTests/fast/dom/element-attribute-js-null.html b/LayoutTests/fast/dom/element-attribute-js-null.html
index 585b1f76e6e12c4e11ed039abf076393e083b270..850191ee6ff319863493a1f42de08753d5f9b443 100644
--- a/LayoutTests/fast/dom/element-attribute-js-null.html
+++ b/LayoutTests/fast/dom/element-attribute-js-null.html
@@ -262,22 +262,24 @@
type: 'HTMLFrameElement',
elementToUse: document.createElement('frame'),
attributes: [
- {name: 'frameBorder', expectedNull: ''},
- {name: 'longDesc', expectedNull: ''},
+ // location is a non-standard attribute, which reflects the src content
+ // attribute when getting, and must therefore be tested before src.
+ {name: 'location', expectedNull: ''},
+ {name: 'frameBorder', expectedNull: 'null'},
+ {name: 'longDesc', expectedNull: 'null', isUrl: true},
{name: 'marginHeight', expectedNull: ''},
{name: 'marginWidth', expectedNull: ''},
- {name: 'name', expectedNull: ''},
- {name: 'scrolling', expectedNull: ''},
- {name: 'src', expectedNull: ''},
- {name: 'location', expectedNull: ''} // not a documented attribute
+ {name: 'name', expectedNull: 'null'},
+ {name: 'scrolling', expectedNull: 'null'},
+ {name: 'src', expectedNull: 'null', isUrl: true}
]
},
{
type: 'HTMLFrameSetElement',
elementToUse: document.createElement('frameset'),
attributes: [
- {name: 'cols', expectedNull: ''},
- {name: 'rows', expectedNull: ''}
+ {name: 'cols', expectedNull: 'null'},
+ {name: 'rows', expectedNull: 'null'}
]
},
{
@@ -315,16 +317,17 @@
type: 'HTMLIFrameElement',
elementToUse: document.createElement('iframe'),
attributes: [
- {name: 'align', expectedNull: ''},
- {name: 'frameBorder', expectedNull: ''},
- {name: 'height', expectedNull: ''},
- {name: 'longDesc', expectedNull: ''},
+ {name: 'align', expectedNull: 'null'},
+ {name: 'frameBorder', expectedNull: 'null'},
+ {name: 'height', expectedNull: 'null'},
+ {name: 'longDesc', expectedNull: 'null', isUrl: true},
{name: 'marginHeight', expectedNull: ''},
{name: 'marginWidth', expectedNull: ''},
- {name: 'name', expectedNull: ''},
- {name: 'scrolling', expectedNull: ''},
- {name: 'src', expectedNull: ''},
- {name: 'width', expectedNull: ''}
+ {name: 'name', expectedNull: 'null'},
+ {name: 'scrolling', expectedNull: 'null'},
+ {name: 'src', expectedNull: 'null', isUrl: true},
+ {name: 'srcdoc', expectedNull: 'null'},
+ {name: 'width', expectedNull: 'null'}
]
},
{
« no previous file with comments | « no previous file | LayoutTests/fast/dom/element-attribute-js-null-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698