Issue 68503013: Remove TreatNullAs=NullString for <frame>, <frameset> and <iframe>

Issue 68503013: Remove TreatNullAs=NullString for <frame>, <frameset> and <iframe> (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, arv+blink, Inactive, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Remove TreatNullAs=NullString for <frame>, <frameset> and <iframe> http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#htmlframeelement http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#htmlframesetelement http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#htmliframeelement http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#HTMLIFrameElement-partial Per spec the longDesc attribute on HTMLFrameElement and HTMLIFrameElement should be reflected as a URL, so make it so. HTMLIFrameElement.sandbox is readonly DOMSettableTokenList in the spec, so leave it with [TreatNullAs=NullString] until that is fixed. The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: IE11 throws exceptions for HTMLFrameElement.scrolling, HTMLIFrameElement.align and HTMLIFrameElement.scrolling, reflects HTMLIFrameElement.width/height as the empty string and does not support HTMLIFrameElement.srcdoc. Opera does not support HTMLIFrameElement.srcdoc. Note that no other browser supports the location attribute, but that has not been touched here. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162147

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -52 lines)			Patch
M	LayoutTests/fast/dom/element-attribute-js-null.html	View		2 chunks	+19 lines, -16 lines	0 comments	Download
M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View		2 chunks	+17 lines, -16 lines	0 comments	Download
M	Source/core/html/HTMLFrameElement.idl	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLFrameElementBase.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLFrameSetElement.idl	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLIFrameElement.idl	View		2 chunks	+9 lines, -10 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/68503013/40001

7 years, 1 month ago (2013-11-15 22:56:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/68503013/40001

7 years, 1 month ago (2013-11-16 00:15:43 UTC) #4

Message was sent while issue was closed.

Change committed as 162147