Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: content/common/media/video_capture_messages.h

Issue 68503005: Reorganize media::VideoCapture* types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 51b76b9a Rebase, comments. Review this please. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/media/video_capture_messages.h
diff --git a/content/common/media/video_capture_messages.h b/content/common/media/video_capture_messages.h
index 50e6f9a59b3b31619271f727ebba47d287f58881..2c280ec5a377bc5b46648030f94e08b80d5f5fc8 100644
--- a/content/common/media/video_capture_messages.h
+++ b/content/common/media/video_capture_messages.h
@@ -14,12 +14,21 @@
#define IPC_MESSAGE_START VideoCaptureMsgStart
IPC_ENUM_TRAITS(content::VideoCaptureState)
-IPC_ENUM_TRAITS_MAX_VALUE(media::VideoCaptureResolutionType,
- media::MaxVideoCaptureResolutionType - 1)
+IPC_ENUM_TRAITS_MAX_VALUE(media::VideoPixelFormat, media::PIXEL_FORMAT_MAX - 1)
+
+IPC_STRUCT_TRAITS_BEGIN(media::VideoCaptureFormat)
+ IPC_STRUCT_TRAITS_MEMBER(frame_size)
+ IPC_STRUCT_TRAITS_MEMBER(frame_rate)
+ IPC_STRUCT_TRAITS_MEMBER(pixel_format)
+IPC_STRUCT_TRAITS_END()
IPC_STRUCT_TRAITS_BEGIN(media::VideoCaptureParams)
- IPC_STRUCT_TRAITS_MEMBER(session_id)
IPC_STRUCT_TRAITS_MEMBER(requested_format)
+ IPC_STRUCT_TRAITS_MEMBER(allow_resolution_change)
+IPC_STRUCT_TRAITS_END()
+
+IPC_STRUCT_TRAITS_BEGIN(media::VideoCaptureCapability)
+ IPC_STRUCT_TRAITS_MEMBER(supported_format)
IPC_STRUCT_TRAITS_END()
// TODO(nick): device_id in these messages is basically just a route_id. We
@@ -53,8 +62,9 @@ IPC_MESSAGE_CONTROL4(VideoCaptureMsg_BufferReady,
// Start a video capture as |device_id|, a new id picked by the renderer
// process. The session to be started is determined by |params.session_id|.
-IPC_MESSAGE_CONTROL2(VideoCaptureHostMsg_Start,
+IPC_MESSAGE_CONTROL3(VideoCaptureHostMsg_Start,
int /* device_id */,
+ media::VideoCaptureSessionId, /* session_id */
media::VideoCaptureParams /* params */)
// Pause the video capture specified by |device_id|.

Powered by Google App Engine
This is Rietveld 408576698