Reorganize media::VideoCapture* types

content/common/media/media_param_traits.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/media/media_param_traits.h"
 
 #include "base/strings/stringprintf.h"
 #include "media/audio/audio_parameters.h"
 #include "media/base/limits.h"
 #include "media/video/capture/video_capture_types.h"
 
 using media::AudioParameters;
 using media::ChannelLayout;
-using media::VideoCaptureFormat;
-using media::VideoCaptureSessionId;
 
 namespace IPC {
 
 void ParamTraits<AudioParameters>::Write(Message* m,
                                          const AudioParameters& p) {
   m->WriteInt(static_cast<int>(p.format()));
   m->WriteInt(static_cast<int>(p.channel_layout()));
   m->WriteInt(p.sample_rate());
   m->WriteInt(p.bits_per_sample());
   m->WriteInt(p.frames_per_buffer());
@@ skipping 21 matching lines @@
   if (!r->IsValid())
     return false;
   return true;
 }
 
 void ParamTraits<AudioParameters>::Log(const AudioParameters& p,
                                        std::string* l) {
   l->append(base::StringPrintf("<AudioParameters>"));
 }
 
-void ParamTraits<VideoCaptureFormat>::Write(Message* m,
-                                            const VideoCaptureFormat& p) {
-  m->WriteInt(p.width);
-  m->WriteInt(p.height);
-  m->WriteInt(p.frame_rate);
-  m->WriteInt(static_cast<int>(p.frame_size_type));
 }
-
-bool ParamTraits<VideoCaptureFormat>::Read(const Message* m,
-                                           PickleIterator* iter,
-                                           VideoCaptureFormat* r) {
-  int frame_size_type;
-  if (!m->ReadInt(iter, &r->width) ||
-      !m->ReadInt(iter, &r->height) ||
-      !m->ReadInt(iter, &r->frame_rate) ||
-      !m->ReadInt(iter, &frame_size_type))
-    return false;
-
-  r->frame_size_type =
-      static_cast<media::VideoCaptureResolutionType>(
-          frame_size_type);
-  if (!r->IsValid())

[ncarter (slow), 2013/11/21 20:15:45]

Where did this validation go?

If we fail to validate these parameters, it could lead to integer overflow in
the size.GetArea() calls. The serializer for gfx::Size doesn't constrained to
the same dimensions as media/base/limits.h .

https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com...

-    return false;
-  return true;
-}
-
-void ParamTraits<VideoCaptureFormat>::Log(const VideoCaptureFormat& p,
-                                          std::string* l) {
-  l->append(base::StringPrintf("<VideoCaptureFormat>"));
-}
-
-}