Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: sdk/bin/dartanalyzer_developer

Issue 68503004: Support symlinking to dart-sdk executables on Linux and Mac. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/bin/dartanalyzer_developer
diff --git a/sdk/bin/dartanalyzer_developer b/sdk/bin/dartanalyzer_developer
index 5639355e16fd89d68c6820922a0216e22b0f6efa..c5363203cf9c82ed0f79ac92e6cb44dabd80ca87 100755
--- a/sdk/bin/dartanalyzer_developer
+++ b/sdk/bin/dartanalyzer_developer
@@ -8,14 +8,6 @@
# the testing infrastructure.
set -e
-function follow_links() {
- while [ -h "$1" ]; do
- # On Mac OS, readlink -f doesn't work.
- 1="$(readlink "$1")"
- done
- echo "$1"
-}
-
FOUND_BATCH=0
for ARG in "$@"
do
@@ -28,11 +20,20 @@ do
esac
done
-# Unlike $0, $BASH_SOURCE points to the absolute path of this file.
-PROG_NAME="$(follow_links "$BASH_SOURCE")"
+function follow_links() {
+ file="$1"
+ while [ -h "$file" ]; do
+ # On Mac OS, readlink -f doesn't work.
+ file="$(readlink "$file")"
+ done
+ echo "$file"
+}
-# Handle the case where the binary dir has been symlinked to.
-CUR_DIR="$(follow_links "$(cd "${PROG_NAME%/*}" ; pwd -P)")"
+# Unlike $0, $BASH_SOURCE points to the absolute path of this file.
ahe 2013/11/14 15:36:05 Weird line endings.
+PROG_NAME="$(follow_links "$BASH_SOURCE")"
+
+# Handle the case where dart-sdk/bin has been symlinked to.
+CUR_DIR="$(cd "${PROG_NAME%/*}" ; pwd -P)"
SDK_DIR="$(cd "${CUR_DIR}/.." ; pwd -P)"

Powered by Google App Engine
This is Rietveld 408576698