Issue 68503002: Delete IBusComponent.

Issue 68503002: Delete IBusComponent. (Closed)

Created:
7 years, 1 month ago by Hiro Komatsu

Modified:
7 years, 1 month ago

Reviewers:
satorux1, Seigo Nonaka

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Delete IBusComponent. IBusComponent is no longer necessary. BUG=317506 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234812

Patch Set 1 #

Patch Set 2 : Rebased. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -495 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_engine_ibus.h	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine_ibus.cc	View	1	3 chunks	+0 lines, -16 lines	0 comments	Download
M	chromeos/chromeos.gyp	View		2 chunks	+0 lines, -3 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_component.h	View		1 chunk	+0 lines, -146 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_component.cc	View		1 chunk	+0 lines, -247 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_component_unittest.cc	View		1 chunk	+0 lines, -79 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Hiro Komatsu

This patch depends on https://codereview.chromium.org/67313006/ Satoru, please review this patch as an owner of chromeos/chromeos.gyp.

7 years, 1 month ago (2013-11-11 08:44:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/68503002/70001

7 years, 1 month ago (2013-11-13 06:09:18 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=223663

7 years, 1 month ago (2013-11-13 08:40:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/68503002/70001

7 years, 1 month ago (2013-11-13 11:46:30 UTC) #6

Message was sent while issue was closed.

Change committed as 234812

Expand Messages | Collapse Messages