Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 685013002: Refactors event dispatching of NativeViewport into its own interface (Closed)

Created:
6 years, 1 month ago by sky
Modified:
6 years, 1 month ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Refactors event dispatching of NativeViewport into its own interface This way the WindowManager can handle the event directly. New flow is for the ViewManager to request the NativeViewportEventDispatcher from the WindowManager and connect said NativeViewportEventDispatcher to the NativeViewport. BUG=none TEST=none R=ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c947eccd5acb557128d9af9f6212a8524e910443

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -194 lines) Patch
M examples/sample_app/sample_app.cc View 1 3 chunks +18 lines, -8 lines 0 comments Download
M examples/surfaces_app/surfaces_app.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_impl.cc View 3 chunks +9 lines, -1 line 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 2 chunks +5 lines, -1 line 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager_internal.mojom View 1 chunk +2 lines, -17 lines 0 comments Download
M mojo/services/view_manager/connection_manager.h View 1 2 6 chunks +9 lines, -4 lines 0 comments Download
M mojo/services/view_manager/connection_manager.cc View 1 2 4 chunks +41 lines, -9 lines 0 comments Download
M mojo/services/view_manager/display_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/view_manager/display_manager.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 4 chunks +11 lines, -52 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
A mojo/services/window_manager/native_viewport_event_dispatcher_impl.h View 1 chunk +33 lines, -0 lines 0 comments Download
A + mojo/services/window_manager/native_viewport_event_dispatcher_impl.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 4 chunks +5 lines, -8 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 2 chunks +5 lines, -4 lines 0 comments Download
D mojo/services/window_manager/window_manager_internal_service_impl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/services/window_manager/window_manager_internal_service_impl.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
6 years, 1 month ago (2014-10-28 22:38:13 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 1 month ago (2014-10-28 22:58:51 UTC) #2
sky
6 years, 1 month ago (2014-10-28 23:49:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c947eccd5acb557128d9af9f6212a8524e910443 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698