Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Issue 685003008: Revert of Widen GPU trigger condition (Closed)

Created:
6 years, 1 month ago by ajuma
Modified:
6 years, 1 month ago
CC:
blink-reviews, ernstm, junchao.han, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

Revert of Widen GPU trigger condition (patchset #3 id:40001 of https://codereview.chromium.org/660133005/) Reason for revert: There's content that depends on the existing trigger in order to opt-out of GPU rasterization. Since we're close to the branch point, let's revert this and then try to expand again in M41. Original issue's description: > Widen GPU trigger condition > > GPU rasterization will be triggered when viewports meet either of the > following conditions: > 1) width=device-width, minimum-scale=X, where X >= 1.0 > 2) width=device-width, user-scalable=no > > BUG=424469 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184566 BUG=424469 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -32 lines) Patch
M Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/tests/ViewportTest.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
D Source/web/tests/data/viewport/viewport-gpu-rasterization-device-width-minimum-scale-0.5.html View 1 chunk +0 lines, -5 lines 0 comments Download
D Source/web/tests/data/viewport/viewport-gpu-rasterization-device-width-minimum-scale-1.5.html View 1 chunk +0 lines, -5 lines 0 comments Download
D Source/web/tests/data/viewport/viewport-gpu-rasterization-device-width-non-user-scalable.html View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ajuma
Created Revert of Widen GPU trigger condition
6 years, 1 month ago (2014-11-05 01:04:12 UTC) #1
ajuma
6 years, 1 month ago (2014-11-05 01:06:12 UTC) #3
ajuma
aelias, PTAL.
6 years, 1 month ago (2014-11-05 01:07:46 UTC) #4
aelias_OOO_until_Jul13
lgtm
6 years, 1 month ago (2014-11-05 01:08:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685003008/1
6 years, 1 month ago (2014-11-05 01:12:06 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 02:16:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184848

Powered by Google App Engine
This is Rietveld 408576698