Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: sky/engine/core/rendering/RenderLayerScrollableArea.cpp

Issue 685003003: Remove a lot of dead Scrollbar methods. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderLayerScrollableArea.cpp
diff --git a/sky/engine/core/rendering/RenderLayerScrollableArea.cpp b/sky/engine/core/rendering/RenderLayerScrollableArea.cpp
index a19578e37dd40f7f33ab97aa36ee5a940c1861a1..a56be11c85d027c84c0019c4eac4e2eb84a88128 100644
--- a/sky/engine/core/rendering/RenderLayerScrollableArea.cpp
+++ b/sky/engine/core/rendering/RenderLayerScrollableArea.cpp
@@ -680,12 +680,6 @@ void RenderLayerScrollableArea::updateAfterStyleChange(const RenderStyle* oldSty
m_vBar->setEnabled(true);
}
- // FIXME: Need to detect a swap from custom to native scrollbars (and vice versa).
- if (m_hBar)
- m_hBar->styleChanged();
- if (m_vBar)
- m_vBar->styleChanged();
-
updateResizerAreaSet();
}
@@ -797,8 +791,7 @@ void RenderLayerScrollableArea::destroyScrollbar(ScrollbarOrientation orientatio
if (!scrollbar)
return;
- if (!scrollbar->isCustomScrollbar())
- willRemoveScrollbar(scrollbar.get(), orientation);
+ willRemoveScrollbar(scrollbar.get(), orientation);
scrollbar->disconnectFromScrollableArea();
scrollbar = nullptr;
@@ -817,12 +810,6 @@ void RenderLayerScrollableArea::setHasHorizontalScrollbar(bool hasScrollbar)
} else {
destroyScrollbar(HorizontalScrollbar);
}
-
- // Destroying or creating one bar can cause our scrollbar corner to come and go. We need to update the opposite scrollbar's style.
- if (m_hBar)
- m_hBar->styleChanged();
- if (m_vBar)
- m_vBar->styleChanged();
}
void RenderLayerScrollableArea::setHasVerticalScrollbar(bool hasScrollbar)
@@ -837,12 +824,6 @@ void RenderLayerScrollableArea::setHasVerticalScrollbar(bool hasScrollbar)
} else {
destroyScrollbar(VerticalScrollbar);
}
-
- // Destroying or creating one bar can cause our scrollbar corner to come and go. We need to update the opposite scrollbar's style.
- if (m_hBar)
- m_hBar->styleChanged();
- if (m_vBar)
- m_vBar->styleChanged();
}
int RenderLayerScrollableArea::verticalScrollbarWidth(OverlayScrollbarSizeRelevancy relevancy) const
« no previous file with comments | « sky/engine/core/page/scrolling/ScrollingCoordinator.cpp ('k') | sky/engine/platform/exported/WebScrollbarImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698