runtime/vm/intrinsifier_ia32.cc - Issue 685003002: Add missing StoreIntoObject calls in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 685003002: Add missing StoreIntoObject calls in generated code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_ia32.cc

===================================================================

--- runtime/vm/intrinsifier_ia32.cc (revision 41605)

+++ runtime/vm/intrinsifier_ia32.cc (working copy)

@@ -243,10 +243,8 @@

// Compare length with capacity.

__ cmpl(EBX, FieldAddress(EDI, Array::length_offset()));

__ j(EQUAL, &fall_through); // Must grow data.

- const Immediate& value_one =

- Immediate(reinterpret_cast<int32_t>(Smi::New(1)));

- // len = len + 1;

- __ addl(FieldAddress(EAX, GrowableObjectArray::length_offset()), value_one);

+ __ IncrementSmiField(FieldAddress(EAX, GrowableObjectArray::length_offset()),

+ 1);

__ movl(EAX, Address(ESP, + 1 * kWordSize)); // Value

ASSERT(kSmiTagShift == 1);

__ StoreIntoObject(EDI,

« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/stub_code_ia32.cc » ('j') | no next file with comments »